Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: Snapshot.created_at should use well-known Timestamp protobuf #330

Closed
jdef opened this issue Nov 13, 2018 · 1 comment
Closed

spec: Snapshot.created_at should use well-known Timestamp protobuf #330

jdef opened this issue Nov 13, 2018 · 1 comment
Assignees
Milestone

Comments

@jdef
Copy link
Member

jdef commented Nov 13, 2018

https://github.com/protocolbuffers/protobuf/blob/master/src/google/protobuf/timestamp.proto

This would be a breaking change after 1.0, so if this change doesn't land before then maybe we could eventually use a oneof to wrap the existing int-based timestamp and a new field that uses Timestamp.

Ideally we'd resolve this prior to 1.0

@saad-ali
Copy link
Member

I support this change.

@jdef jdef assigned jdef and unassigned jieyu and saad-ali Nov 13, 2018
@jdef jdef added this to the v1.0 milestone Nov 13, 2018
jdef pushed a commit to jdef/spec that referenced this issue Nov 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants