State commit / cleanup #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| public RecordQueue(TopicPartition partition, SourceNode source) { | ||
| this.partition = partition; | ||
| this.source = source; | ||
|
|
||
| this.fifoQueue = new ArrayDeque<>(); |
There was a problem hiding this comment.
Why did you move these trivial variable initializations to constructor?
Is it the recommended Kafka coding style? Just wondering.
There was a problem hiding this comment.
Not really kafka conventions but just personal coding style.
There was a problem hiding this comment.
Is there an issue for moving tirivial initialization to constructor?
|
Left a minor comment. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ymatsuda
Task state commit can happen either when user called context.commit() during the processing of a record in any processor, or when the commit interval has reached. In the first case, the task will commit it state including local state store, consumed offset and produced record; in the latter case, the thread will just commit the states of all tasks it owns.
Did not have the threshold on total #. buffered records across tasks, since after chatting to @hachikuji I feel poll(0)'s overhead is very minimal, and asking users to specify the threshold could be hard since there is already a config for per-partition max buffered records.
Some minor fixes on metrics recording, state cleanup, etc.