refactor TopologyBuilder #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 26, 2015 14:40
| for (String topic : topics) { | ||
| if (topicsToSourceNames.containsKey(topic)) | ||
| if (sourceTopicNames.contains(topic)) |
There was a problem hiding this comment.
topics are not added to sourceTopicNames.
|
A couple of comments, otherwise LGTM. |
|
LGTM! |
andrewegel
pushed a commit
that referenced
this pull request
Nov 16, 2021
* Squashed 'mk-include/' content from commit 9bdd40520 git-subtree-dir: mk-include git-subtree-split: 9bdd405204f66179031f7f42275ab38641b495b4 * Updated makefile for mk-include * Changing to jfrog * Updating release branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@guozhangwang
Simpler topology construction by taking an advantage that sources/sinks/processors are always added in a topological order. Processor nodes are constructed in the same order as API calls (addSource, addSink, addProcessor). I will use this guarantee in the join support.