Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed e2e bgcheck + passport tests #168

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Fixed e2e bgcheck + passport tests #168

merged 1 commit into from
Oct 18, 2023

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Oct 17, 2023

  • Bins are installed locally
  • Reduced noisy output
  • Use as much local resources as possible (AS/RVPS still uses a hardcoded /opt/coco location, issue here)
  • Reorganized the e2e test, with pid files and orderly service startup/shutdown

@mkulke mkulke mentioned this pull request Oct 17, 2023
Merged
Xynnn007
Xynnn007 approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@Xynnn007 Xynnn007 merged commit 730f7ed into confidential-containers:main Oct 18, 2023
@mkulke mkulke deleted the mkulke/fix-e2e-tests branch October 18, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xynnn007 Xynnn007 Xynnn007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkulke @Xynnn007