Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recreate Cargo.lock file to retrieve latest AS #165

Merged

Conversation

mkulke
Copy link
Contributor

@mkulke mkulke commented Oct 5, 2023

Since kbs references AS head, we just need to recreate a lock file

@surajssd
Copy link
Member

surajssd commented Oct 6, 2023

cc: @Xynnn007 @jialez0 @sameo

@Xynnn007
Copy link
Member

Xynnn007 commented Oct 7, 2023

@mkulke Hey Magnus, could you help to check the error in e2e CI?

@mkulke
Copy link
Contributor Author

mkulke commented Oct 9, 2023

@mkulke Hey Magnus, could you help to check the error in e2e CI?

yup, I'll take a look.

Something else, can we register a webhook on the kbs repo - so we can run e2e tests on an azure cvm runner?

@Xynnn007
Copy link
Member

@mkulke Hey Magnus, could you help to check the error in e2e CI?

yup, I'll take a look.

Something else, can we register a webhook on the kbs repo - so we can run e2e tests on an azure cvm runner?

Sounds a good idea. Could you make an issue for this?

@mkulke
Copy link
Contributor Author

mkulke commented Oct 17, 2023

@mkulke Hey Magnus, could you help to check the error in e2e CI?

@Xynnn007 PTAL #168

I'll rebase this then

@Xynnn007
Copy link
Member

@mkulke Hey Magnus, could you help to check the error in e2e CI?

@Xynnn007 PTAL #168

I'll rebase this then

Done

@mythi
Copy link
Contributor

mythi commented Oct 18, 2023

Since kbs references AS head, we just need to recreate a lock file

Sort of related: I've been wondering if coco-as-builtin is the best choice as the default feature since it forces to install all the verifier dependencies.

@mkulke mkulke force-pushed the mkulke/bump-as-version branch 2 times, most recently from 99a3b01 to c760300 Compare October 18, 2023 06:12
@Xynnn007 Xynnn007 merged commit c6f5b13 into confidential-containers:main Oct 28, 2023
@mkulke mkulke deleted the mkulke/bump-as-version branch October 28, 2023 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants