Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Use multiple docker images #6

Conversation

jakirkham
Copy link
Member

Attempts to use multiple Docker images for the build.

Checklist

  • Used a fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

In order to ensure the `docker_image` is incorporated into re-rendering,
this adds the variant to a special section within `extra`.
…da-forge-pinning 2019.07.23

Now that the `docker_image` variant is included in the `meta.yaml`,
re-render to update the feedstock configuration files to each use their
own Docker image.
@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

  • The extra section contained an unexpected subsection name. variants is not a valid subsection name.

@@ -72,3 +72,6 @@ extra:
- Akshay-Venkatesh
- jakirkham
- TomAugspurger

variants:
docker_image: {{ docker_image }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds the variant to extra to ensure that conda-build will recognize this is used and create the full matrix.

Thanks @jjhelmus for the suggestion. 🙂

@jakirkham jakirkham mentioned this pull request Sep 20, 2019
5 tasks
@jakirkham jakirkham deleted the use_multiple_docker_images branch September 20, 2019 19:18
jakirkham pushed a commit to jakirkham-feedstocks/ucx-split-feedstock that referenced this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants