Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building against multiple Docker images #1125

Closed
jakirkham opened this issue Aug 15, 2019 · 7 comments
Closed

Building against multiple Docker images #1125

jakirkham opened this issue Aug 15, 2019 · 7 comments

Comments

@jakirkham
Copy link
Member

Looking at PR ( #1070 ), it seems we assume there should only be one relevant docker_image in each config. Am curious if there is a reason for that assumption? More importantly would it be reasonable to generalize this to allow more than one docker_image?

@jakirkham
Copy link
Member Author

cc @isuruf @mariusvniekerk

@isuruf
Copy link
Member

isuruf commented Aug 15, 2019

Each config should have one docker_image. If you want to build against multiple docker images, you can have multiple configs.

@isuruf isuruf closed this as completed Aug 15, 2019
@jakirkham
Copy link
Member Author

I don't quite follow. Was thinking docker_image could be a list in conda_build_config.yaml and it would try each one. However it appears to be grabbing the last value by sorted order. I'm guessing this will also be a problem when handing this for GPU packages generally ( conda-forge/conda-forge-pinning-feedstock#237 ). Take PR ( conda-forge/ucx-split-feedstock#6 ) for example. Is there a different way I should be doing this or is this not possible without making changes to conda-smithy?

@isuruf
Copy link
Member

isuruf commented Aug 19, 2019

You need to make docker_image or another variable that is zipped with it be a used variable.

@jakirkham
Copy link
Member Author

Why is that needed?

@isuruf
Copy link
Member

isuruf commented Aug 19, 2019

That's how conda-smithy works. Just because there are 3 python versions in conda_build_config.yaml, that doesn't mean there are 3 jobs for recipes not using python. You need to use docker_image somewhere in the recipe (or a variable zipped with it).

@jakirkham
Copy link
Member Author

I see. So you just mean it needs to be used in the meta.yaml somehow. Yeah that makes sense. Thanks. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants