Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove current repodata hacks #74

Closed
wants to merge 1 commit into from
Closed

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Oct 7, 2024

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.
I do have some suggestions for making it better though...

For recipe/meta.yaml:

  • License exception is not an SPDX exception.

Documentation on acceptable licenses can be found here.

@beckermr
Copy link
Member

beckermr commented Oct 7, 2024

I guess missed a bit my other PR. Lgtm!

@beckermr
Copy link
Member

beckermr commented Oct 7, 2024

That was #70 in order to Xref the GitHub links.

@isuruf
Copy link
Member Author

isuruf commented Oct 7, 2024

nvm, I was using an older commit

@isuruf isuruf closed this Oct 7, 2024
@h-vetinari
Copy link
Member

So now that both this and #72 have been closed, what's the way forward for conda-forge/ctng-compilers-feedstock#147?

I maintain that #72 would be the proper way to do it (and would also rectify the situation that it's hard to tell where sysroot-with-crypt builds come from, as the existing ones just got the label added manually), but if you prefer to do it on top of v2.17 then I don't care. It should just be done one way or another (I guess a third option is something like #75 but for v2.17?).

(BTW, while looking at the branches I noticed that the tzdata changes have never been forward-ported from #66 to main)

@isuruf
Copy link
Member Author

isuruf commented Oct 9, 2024

See #73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants