-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop outdated sysroot #147
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@isuruf, can you let me know how you'd like to proceed here? should I create a branch for the |
@isuruf, given that we'll have to wait several more months at least to get rid of the sysroot hacks, would you be OK with me creating a |
Ping @isuruf for how to proceed here. |
Let's create 2.17 packages with crypt in it. |
Can you send a PR to linux-sysroot-feedstock? |
I can, but it needs a new branch before the crypt removal (which would go well with the label we're already using). I can create it if you want. |
Can you send a PR against 2.17 branch? I can merge directly to a new merge. |
The 2.17 branch has advanced too far. We should branch off earlier. Take a look at the branch I've already created (on my own fork) that's linked in the OP. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12921318586. Examine the logs at this URL for more detail. |
This reverts commit dbf9a48.
…onda-forge-pinning 2024.12.26.18.39.45
…onda-forge-pinning 2025.01.06.12.46.45
After conda-forge/linux-sysroot-feedstock#73 & conda-forge/conda-forge-ci-setup-feedstock#373 we're getting closer here, but still running into an issue related to the cross-compilation sysroot for s390x. At first I misread the CI failure for 3afde80 to be due to
Independent of the question of whether that's a worthwhile change (I think so) and whether we want to do it as part of this PR (no strong preference from my side), the following error still persists.
That's despite the sysroot environment being created successfully, and
and the fact that the sysroot definitely contains Any ideas @isuruf @beckermr? My best guess is that the |
…nda-forge-pinning 2025.01.22.17.59.35
Wanted to check if newer sysroots somehow change anything. 2.28 didn't (aside from the fact that we have no builds with crypt, but GCC 14 should have worked), and for 2.34, we get
Which is certainly a surprise for me, given that glibc 2.34 was released 3.5 years ago, and GCC 12-14 were all released after that. |
Something I descoped from #142 because AFAICT we either need to rebuild the
sysroot-with-crypt
for 2.17 without the track_features (here's a branch how this would look like; consists of rebasing v2.17 on the last commit before crypt-removal), or we'd need to do something like conda-forge/linux-sysroot-feedstock#68