-
-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gpu/cpu mutex naming #1059
Comments
I would prefer the usage of |
Thanks @xhochy for the suggestion. I agree. When we have other gpu variants like AMD ones, this will be useful. |
This has already come up for xgboost fwiw. |
|
That said, I’m not entirely sure why we want to disrupt the naming scheme. This will cause a headache for people using these packages for what it sounds to be purely cosmetic reasons. Before making changes here I’d be interested in hearing about what actual problems this is causing. |
Because as a community we need to come to a consensus on how to do this. There are various different schemes. Like in the Btw, we can make this change without disrupting anything by adding a compatibility layer for previous packages or just not touching previous packages. |
Where do we stand on the mutual exclusivity of the variants? I know in general this is up to the package itself and how it is structured, but a package that wants labeled variants that are not mutually exclusive would have a harder time with a mutex, for example. |
Thus far we have not added a mutex in that case. |
@beckermr, can you explain more? Is it like python2 and python3 in the same env? |
My question is not terribly well formulated but I can imagine as a user wanting both packages for cpus and gpus in the same env. Much of this depends on the actual package and how it is structured. |
No it’s a fair question. This can come up when the GPU bits live in a separate shared object. |
But keep compatibility package names with pytorch-channel. Xref. conda-forge/conda-forge.github.io#1059
I also prefer cuda to gpu |
Since conda-forge/pytorch-cpu-feedstock#22, that feedstock has the following build strings:
I had asked in that PR:
Copying this here because I'd like to have an idea of what should be used before I go forward with the adaptation in conda-forge/faiss-split-feedstock#19. |
For cpu-gpu mutex: In this recipe I showed that it's possible to do a per-recipe mutex: But, as discussed above whether a mutex is required is really up to the package's design and structure. I can imagine a CPU and GPU build coexist in the same package happily. For the naming convention: I support |
cc @conda-forge/core
As we are adding more packages, we have to decide on the naming.
Currently most packages use
<pkg>-proc=*=cpu
and<pkg>-proc=*=gpu
. While it is great to have a uniform naming scheme, I don't particularly like the-proc
name since the name doesn't mean anything. We should decide on the naming soon.We can fix already existing packages to work with the new name and the old name if we decide on a new name.
The text was updated successfully, but these errors were encountered: