-
-
Notifications
You must be signed in to change notification settings - Fork 351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove uninstallable mpifort #391
Conversation
This specific build of mpi-fort is uninstallable because it requires the corresponding compiler build which doesn't exist?
Related to conda-forge/staged-recipes#14726 because mamba has decided it needs this build of mpifort, even though there is a newer version available. |
@conda-forge/openmpi |
Thanks, @carterbox. Good catch. I should have done this in #17... Since you're at it, would you mind also removing |
These are the package infos. |
Why can't one just leave them in here then bump the build number |
There already is a newer build of these packages, but the solver chooses these old ones anyways. I don't know why. The problem is that these packages have a pinned dependency on a build of openmpi that was already marked as broken, so they cannot be installed. It seems better to mark these uninstallable packages as broken than to modify every recipe to avoid this specific build of these packages. |
Thoughts @conda-forge/core? 🙂 |
I believe the issue is that you need to add the cuda compilers so that the recepe generates multiple build strings of mpifort Should look like:
That way your build matrix gets built out. |
Hmm, nevermind. I mean honestly, probably some edge case is getting hit. I'm ok with moving on from this. But hopefully we can write some good guides to compiling with GPU support. For one, I don't think we've documented good build string conventions and best practicies for pinning gpu/cpu. |
Probably best to continue that discussion in issue ( conda-forge/conda-forge.github.io#1059 ) (assuming this is covering the same thing) |
The recipe that caused me the find this issue is for a non-cuda package, so I'm not sure how any of this is related. |
Thanks for merging. |
Nor am I. Though I haven't spent any time digging into this |
This specific build of mpi-fort is uninstallable because it requires the corresponding compiler build which doesn't exist? Perhaps that build was already removed for being broken, but they forgot to remove this package too?
Guidelines for marking packages as broken:
instead of marking packages as broken. This alternative workflow makes environments more reproducible.
not technically broken and should not be marked as such.
but should be patched in the repo data and be marked unbroken later.
the maintainers only, we can allow packages to be marked broken more liberally.
conda-forge/core
) try to make a decision on these requests within 24 hours.What will happen when a package is marked broken?
broken
label to the package. Themain
label will remain on the package and this is normal.anaconda.org
CDN picks up the new patches, you will no longer be able to install the package from themain
channel.Checklist:
broken/*
for adding thebroken
label,not_broken/*
for removing thebroken
label, ortoken_reset/*
for token resets)