fix MakeFunctionCallable's codegen when return type is a function pointer
#502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vipul-Cariappa
force-pushed
the
dev/func-callback-codegen
branch
from
64d02c5 to
3dcb1c8
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -920,6 +926,12 @@ TEST(FunctionReflectionTest, GetFunctionCallWrapper) { | |||
| FCI4.Invoke(&ret4); | |||
| EXPECT_EQ(ret4, 4); | |||
|
|
|||
| typedef int (*int_func)(void); | |||
There was a problem hiding this comment.
warning: redundant void argument list in typedef [modernize-redundant-void-arg]
Suggested change
| typedef int (*int_func)(void); | |
| typedef int (*int_func)(); |
| @@ -920,6 +926,12 @@ TEST(FunctionReflectionTest, GetFunctionCallWrapper) { | |||
| FCI4.Invoke(&ret4); | |||
| EXPECT_EQ(ret4, 4); | |||
|
|
|||
| typedef int (*int_func)(void); | |||
| int_func callback = nullptr; | |||
| FCI5.Invoke(&callback); | |||
There was a problem hiding this comment.
warning: multilevel pointer conversion from 'int_func *' (aka 'int (**)()') to 'void *', please use explicit cast [bugprone-multi-level-implicit-pointer-conversion]
FCI5.Invoke(&callback);
^
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #502 +/- ##
==========================================
+ Coverage 71.26% 71.63% +0.36%
==========================================
Files 9 9
Lines 3564 3568 +4
==========================================
+ Hits 2540 2556 +16
+ Misses 1024 1012 -12
... and 1 file with indirect coverage changes
|
vgvassilev
reviewed
Feb 16, 2025
Vipul-Cariappa
force-pushed
the
dev/func-callback-codegen
branch
from
3dcb1c8 to
2b096c7
Compare
vgvassilev
approved these changes
Feb 18, 2025
Vipul-Cariappa
added a commit
to Vipul-Cariappa/cppyy-compiler-research
that referenced
this pull request
Feb 21, 2025
`test01_instance_data_read_access` fixed by compiler-research/cppyy-backend#128 (enum changes) others fixed by compiler-research/CPyCppyy#82 & compiler-research/CppInterOp#502
Vipul-Cariappa
added a commit
to compiler-research/cppyy
that referenced
this pull request
Feb 22, 2025
`test01_instance_data_read_access` fixed by compiler-research/cppyy-backend#128 (enum changes) others fixed by compiler-research/CPyCppyy#82 & compiler-research/CppInterOp#502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes code generation of
MakeFunctionCallablefor the cases where the return type of the function is a function pointer.Fixes # (issue)
Potentially fix 4 tests at cppyy.
Type of change
Please tick all options which are relevant.
Testing
Implemented a test case where it used to fail, but passed with these changes.
Checklist