fix to use function pointers #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vipul-Cariappa
force-pushed
the
dev/func-pointers
branch
from
70808b6 to
a9f0fd5
Compare
vgvassilev
reviewed
Feb 20, 2025
| @@ -2610,6 +2610,12 @@ static void* PyFunction_AsCPointer(PyObject* pyobject, | |||
| // function pointer. The former is direct, the latter involves a JIT-ed wrapper. | |||
| static PyObject* sWrapperCacheEraser = PyCFunction_New(&gWrapperCacheEraserMethodDef, nullptr); | |||
|
|
|||
| // FIXME: avoid string comparisons and parsing | |||
| std::string true_signature = signature; | |||
| true_signature.erase(std::remove(true_signature.begin(), true_signature.end(), ' '), true_signature.end()); | |||
There was a problem hiding this comment.
Can you give an example what's the type of things new get and we should edit out?
There was a problem hiding this comment.
I realize we should probably move forward with this PR. We could probably do a better job at the converter comparison level but that's probably good enough to make progress...
Vipul-Cariappa
added a commit
to Vipul-Cariappa/cppyy-compiler-research
that referenced
this pull request
Feb 21, 2025
`test01_instance_data_read_access` fixed by compiler-research/cppyy-backend#128 (enum changes) others fixed by compiler-research/CPyCppyy#82 & compiler-research/CppInterOp#502
Vipul-Cariappa
added a commit
to compiler-research/cppyy
that referenced
this pull request
Feb 22, 2025
`test01_instance_data_read_access` fixed by compiler-research/cppyy-backend#128 (enum changes) others fixed by compiler-research/CPyCppyy#82 & compiler-research/CppInterOp#502
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on compiler-research/cppyy-backend#128