Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code-gen: fix field types of update partial for optional fields #647

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

dirkdev98
Copy link
Member

Closes #643

@dirkdev98 dirkdev98 enabled auto-merge (squash) February 2, 2021 19:08
@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2021

==== Benchmark result ====

Node.js version: 15
Total benchmarks: 15
          Passed: 15
          Failed: 0
-----------
router - github static path              200000  iterations    8935  ns/op
router - github path params              100000  iterations   11325  ns/op
compas validator simple                 5000000  iterations     272  ns/op
yup validator simple                     100000  iterations   13182  ns/op
fastest-validator validator simple     10000000  iterations     109  ns/op
compas validator nested                 1000000  iterations    1549  ns/op
yup validator nested                      20000  iterations   52592  ns/op
fastest-validator validator nested      2000000  iterations     574  ns/op
logger - strings                         500000  iterations    2800  ns/op
logger - objects                         500000  iterations    3423  ns/op
logger - deep objects                    500000  iterations    5654  ns/op
uuid                                    5000000  iterations     390  ns/op
uuid.isValid                           10000000  iterations     153  ns/op
isNil                                 500000000  iterations       0  ns/op
isPlainObject                          50000000  iterations      21  ns/op

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2021

==== Benchmark result ====

Node.js version: 14
Total benchmarks: 15
          Passed: 15
          Failed: 0
-----------
router - github static path              200000  iterations    8192  ns/op
router - github path params              100000  iterations   10032  ns/op
compas validator simple                 5000000  iterations     260  ns/op
yup validator simple                     100000  iterations   12799  ns/op
fastest-validator validator simple     10000000  iterations     124  ns/op
compas validator nested                 1000000  iterations    1386  ns/op
yup validator nested                      50000  iterations   39341  ns/op
fastest-validator validator nested      2000000  iterations     550  ns/op
logger - strings                         500000  iterations    2866  ns/op
logger - objects                         500000  iterations    3383  ns/op
logger - deep objects                    500000  iterations    5854  ns/op
uuid                                    2000000  iterations     508  ns/op
uuid.isValid                           10000000  iterations     172  ns/op
isNil                                 500000000  iterations       0  ns/op
isPlainObject                         100000000  iterations      19  ns/op

@github-actions
Copy link
Contributor

github-actions bot commented Feb 2, 2021

==== C8 test coverage ====
Statements: 66.19% ( 24515/37036 )
Branches : 65.47% ( 2688 /4106 )
Functions : 65.93% ( 811 /1230 )
Lines : 66.19% ( 24515 /37036 )

@dirkdev98 dirkdev98 merged commit bde2631 into main Feb 2, 2021
@dirkdev98 dirkdev98 deleted the fix/code-gen-nullable-upade-field branch February 2, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code-gen: sql update type should indicate null values as well as undefined
1 participant