code-gen: fix field types of update partial for optional fields (#647)

Closes #643
compasjs · Feb 2, 2021 · bde2631 · bde2631
1 parent 824da04
commit bde2631
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/code-gen/src/generator/sql/partial-type.js b/packages/code-gen/src/generator/sql/partial-type.js
@@ -1,3 +1,4 @@
+import { isNil } from "@compas/stdlib";
 import { ObjectType } from "../../builders/ObjectType.js";
 import { upperCaseFirst } from "../../utils.js";
 import { js } from "../tag/index.js";
@@ -73,6 +74,15 @@ export function createPartialTypes(context) {
         ...fieldType,
         isOptional: true,
       };
+
+      // Create correct types by setting allowNull, since the value will be used in the update statement
+      if (fieldType.isOptional && isNil(fieldType.defaultValue)) {
+        updatePartial.keys[key].validator = Object.assign(
+          {},
+          updatePartial.keys[key].validator,
+          { allowNull: true },
+        );
+      }
     }
 
     type.partial = {

diff --git a/packages/store/src/generated/types.js b/packages/store/src/generated/types.js