Feature/COMPAS FAB GH components

[romanarust]

What type of change is this?

Draft for COMPAS FAB GH components made with the Python GHPY compiler.
Based on the Tutorial by Giulio Piacentino, which provides a transparent way of dealing with future versions of this components.

For review, you have to run src\compas_fab\ghpython\components\compile.py from Rhino's PythonScriptEditor.
The library is then copied into 'USER\AppData\Roaming\Grasshopper\Libraries'

If you open Grasshopper, you'll see something like the following (icons need to be updated of course):

The robot_playground.ghx is updated with these components.

• Bug fix in a backwards-compatible manner.
• New feature in a backwards-compatible manner.
• Breaking change: bug fix or new feature that involve incompatible API changes.
• Other (e.g. doc update, configuration, etc)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

• I added a line to the CHANGELOG.rst file in the Unreleased section under the most fitting heading (e.g. Added, Changed, Removed).
• I ran all tests on my computer and it's all green (i.e. invoke test).
• I ran lint on my computer and there are no errors (i.e. invoke lint).
• I added new functions/classes and made them available on a second-level import, e.g. compas_fab.robots.Configuration.
• I have added tests that prove my fix is effective or that my feature works.
• I have added necessary documentation (if appropriate)

[gonzalocasas]

Looks very good!!
I added a couple of comments here and there, besides that, it seems the linter is complaining about some stuff, and I would add a short bit of documentation somewhere indicating the compilation process. Ideally also add a def in tasks.py so that it can be triggered like all other dev tasks.

[gonzalocasas]

maybe best here would be to use the same string we use for the overall compas_fab version. The way to do that is to 1) use the current version here, and 2) add this file and search/replace condition to the .bumpversion.cfg file on the root of the repo.

[romanarust]

I changed bumpversion and added a few lines in 'CONTRIBUTING.rst'. But would need some help on adding a task and the naming of that task.
I created a file named install.py in src\compas_fab\ghpython\components\ that should be executed.

[gonzalocasas]

I think we have functions in compas_rhino.__init__ that can help you retrieve this folder dynamically.

[gonzalocasas]

Since we have a build step, it would probably make sense to have these icon files as files and create the base64 encoded string at compile-time.

[gonzalocasas]

Isn't it more complicated to return this tuple instead of just ros_client, considering is_connected is also available on ros_client.is_connected?

[romanarust]

returning the bool as well is practical from a user perspective: you can simply add a textfield (panel) to that outlet, see below:

[romanarust]

Alternatively, compas core could gain the ability to know how to install GH components instead, and then we would only need to provide the component locations.

I think that would be the way to go. I will open a draft PR on compas to get that started in parallel.

As a third alternative, we could add for now an entry-point like compas_fab.ghpython.install and do this completely in here. If we go that route, it would be a temp solution until we move it to core.

Yes, this as temp solution that sounds right. Could you @gonzalocasas add this?

[gonzalocasas]

Yes, this as temp solution that sounds right. Could you @gonzalocasas add this?

yep, will do