Grasshopper GHPY libraries install #770
Conversation
|
@romanarust I made the method public, because we'll be using it from |
| for item in result: | ||
| try: | ||
| package, message, success = item | ||
| status = 'OK' if success else 'ERROR' |
There was a problem hiding this comment.
should an error here result in an exit_code = -1?
There was a problem hiding this comment.
you're right, fixed at 7b6ef0d
There was a problem hiding this comment.
I think it's a little more complicated. Shouldn't all the successes be collected into some list successes and then instead of returning True, all(successes) is returned?
|
just as fyi, this is how the thing runs with a simple (fake) implementation of the pluggable:
|
src/compas_rhino/install.py
Outdated
| status = 'OK' if success else 'ERROR' | ||
| print(' {} {}: {}'.format(package.ljust(20), status, message)) | ||
| except ValueError: | ||
| post_execution_errors.append(ValueError('Step successful, but result is wrongly formatted: {}'.format(str(result)))) |
There was a problem hiding this comment.
and here, should result be item?
src/compas_rhino/install.py
Outdated
| for error in post_execution_errors: | ||
| print(' - {}'.format(repr(error))) | ||
|
|
||
| return False |
There was a problem hiding this comment.
This is confusing to me. If there are post_execution_errors, then it's been printed that the step was successful, but now we are getting an -1 exit code. So is it a success or an error?
There was a problem hiding this comment.
I guess it's that I don't like the message of the ValueError. If the result isn't formatted correctly how can it be assume that the step was successful?
There was a problem hiding this comment.
ahh... mmm... fair point. how about: ValueError('Step ran without errors but result is wrongly formatted: {}'.format(str(item))?
There was a problem hiding this comment.
that is a less confusing message for me.
On COMPAS FAB we started to make Grasshopper components that are compiled in a library (.GHPY) (compas-dev/compas_fab#249).
For installing that library, it needs to be copied into the Grasshopper library path. This action is ideally executed when calling
python -m compas_rhino.installAs suggested by @gonzalocasas, compas core should know how to install GH components, and other packages only need to provide the component locations.
For the time being, we're providing two extension points (
pluggableinterfaces) to allow hooking up into the install/uninstall and do arbitrary stuff. This will be a good solution until we sort out all the details of the installation (and potentially compilation) of GH components on end-user machines.What type of change is this?
Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.CHANGELOG.mdfile in theUnreleasedsection under the most fitting heading (e.g.Added,Changed,Removed).invoke test).invoke lint).compas.datastructures.Mesh.