Expanded the previously added Chinese RAV4 #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came after testing a different trim level. This fingerprint is confirmed working on both.
|
It did?
…On Nov 7, 2018, 5:24 PM -0500, ErichMoraga ***@***.***>, wrote:
This came after testing a different trim level. This fingerprint is confirmed working on both.
You can view, comment on, or merge this pull request online at:
#425
Commit Summary
• Expanded the previously added Chinese RAV4
File Changes
• M selfdrive/car/toyota/values.py (2)
Patch Links:
• https://github.com/commaai/openpilot/pull/425.patch
• https://github.com/commaai/openpilot/pull/425.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Yes. |
|
Okay just wanted to make sure.
…On Nov 7, 2018, 7:11 PM -0500, ErichMoraga ***@***.***>, wrote:
Yes.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Thanks @ErichMoraga . |
|
This one includes all the other's msgs., adds an extra 11, and works for both trims. No need to keep the previous fingerprint, which is why I replaced it. |
klaus385
pushed a commit
to klaus385/openpilot
that referenced
this pull request
Dec 31, 2018
This came after testing a different trim level. This fingerprint is confirmed working on both.
dragonpilot
pushed a commit
to dragonpilot-community/dragonpilot
that referenced
this pull request
Apr 7, 2020
This came after testing a different trim level. This fingerprint is confirmed working on both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came after testing a different trim level. This fingerprint is confirmed working on both.