Nicki Minaj Model #28218
Merged
Nicki Minaj Model #28218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellgoffpc
force-pushed
the
nicki-model
branch
from
a3f2a7f to
e3cf185
Compare
|
👩🎤 |
|
How does this model improve? |
|
|
FrogAi
added a commit
to FrogAi/FrogPilot
that referenced
this pull request
May 18, 2023
FrogAi
added a commit
to FrogAi/FrogPilot
that referenced
this pull request
May 18, 2023
FrogAi
added a commit
to FrogAi/FrogPilot
that referenced
this pull request
May 18, 2023
FrogAi
added a commit
to FrogAi/FrogPilot
that referenced
this pull request
May 18, 2023
FrogAi
added a commit
to FrogAi/FrogPilot
that referenced
this pull request
May 18, 2023
FrogAi
added a commit
to FrogAi/FrogPilot
that referenced
this pull request
May 18, 2023
FrogAi
added a commit
to FrogAi/FrogPilot
that referenced
this pull request
May 18, 2023
FrogAi
added a commit
to FrogAi/FrogPilot
that referenced
this pull request
May 18, 2023
crwusiz
pushed a commit
to jmtechn-as/openpilot
that referenced
this pull request
Nov 12, 2023
nworb-cire
pushed a commit
to opgm/openpilot
that referenced
this pull request
Aug 2, 2024
* UI: Display E2E Longitudinal status icon * don't forget init * take these out * and this * can't leave this * spam the event * publish here instead * try this now * expose the toggle * Spam all the time!!! * Spam all the time with this! * see if this works * new way to trigger * fix * another one * more to it * more of that * move to car controls instead * no longer needed * 20 hz * unnecessary * send like this pls * move to long planner * let's see what it looks like first * don't alert yet lol * re-enable and try out prompt! * move chime event to longitudinal_planner * AlertStatus to userPrompt * Add more reset conditions * less conditions to test first * louder sound * permanent alert * LOUDER SON! * use stock prompt * Revert "less conditions to test first" This reverts commit b24a096e65e80f303f7d92072cdf273a30dd37e2. * remove lead car take off alert (in separate PR) * cleanup * longer * Nicki Minaj Model (commaai#28218) * New model: 2ff7490f-8a2f-4c0d-87a8-b0fa3a4a6a71 * Updated model_replay_ref_commit (cherry picked from commit 328b5d9) * use the event * move logic to c++ * cleanup * no prompt border * use brake light from car state * lead car take off event * lead car take off event * always reset last distance * show border when prompted * remove lead car take off alert (in separate PR) * don't prompt when lead car detected * Revert "Nicki Minaj Model (commaai#28218)" This reverts commit b25e96c9d8fe0ac3a93c97eec2e91064c12a5649. * bad sounds * simpler --------- Co-authored-by: Mitchell Goff <[email protected]>
nworb-cire
pushed a commit
to opgm/openpilot
that referenced
this pull request
Aug 2, 2024
* UI: Display E2E Longitudinal status icon * don't forget init * take these out * and this * can't leave this * spam the event * publish here instead * try this now * expose the toggle * Spam all the time!!! * Spam all the time with this! * see if this works * new way to trigger * fix * another one * more to it * more of that * move to car controls instead * no longer needed * 20 hz * unnecessary * send like this pls * move to long planner * let's see what it looks like first * don't alert yet lol * re-enable and try out prompt! * move chime event to longitudinal_planner * AlertStatus to userPrompt * Add more reset conditions * less conditions to test first * louder sound * permanent alert * LOUDER SON! * use stock prompt * Revert "less conditions to test first" This reverts commit b24a096e65e80f303f7d92072cdf273a30dd37e2. * remove lead car take off alert (in separate PR) * cleanup * longer * Nicki Minaj Model (commaai#28218) * New model: 2ff7490f-8a2f-4c0d-87a8-b0fa3a4a6a71 * Updated model_replay_ref_commit (cherry picked from commit 328b5d9) * use the event * move logic to c++ * cleanup * no prompt border * use brake light from car state * lead car take off event * lead car take off event * always reset last distance * show border when prompted * remove lead car take off alert (in separate PR) * don't prompt when lead car detected * Revert "Nicki Minaj Model (commaai#28218)" This reverts commit b25e96c9d8fe0ac3a93c97eec2e91064c12a5649. * bad sounds * simpler * lead car takeoff prompt * log to tmux * Nicki Minaj Model (commaai#28218) * New model: 2ff7490f-8a2f-4c0d-87a8-b0fa3a4a6a71 * Updated model_replay_ref_commit (cherry picked from commit 328b5d9) * only print when stopping or starting * remove debug msgs * Revert "Nicki Minaj Model (commaai#28218)" This reverts commit 4fa06f12db858f65570bbf4bc2d9ee1709aead19. --------- Co-authored-by: Mitchell Goff <[email protected]>
nworb-cire
pushed a commit
to opgm/openpilot
that referenced
this pull request
Aug 2, 2024
* Custom Stock Longitudinal Control - base * HKG * simpler * expose toggle * allow events and engagements * gate hysteresis for now * screen tap SLC logic * Honda * update with submaster * Revert "simpler" This reverts commit 61b9a02faec721d4460c50c6e3f81b7d459d506b. * send to cereal * handle new pcm cruise engagement on HKG * small cleanup * define vehicle-specific lowest set speed * not fitting * new logic to help with weird rapid spam * comment * gaspressed don't override * slow down button send when 2 values away * less complex * round them up * Revert "less complex" This reverts commit d850c404cccca5940f4e861c5df0317a38a4ab6b. * gotta convert * only slow down for slc and normal * gaspress allow override * no delay * gate behind custom stock long * add hysteresis to curve speed button sends * remove limiting for Honda * Revert "remove limiting for Honda" This reverts commit b50f6199508e313fa1a30e1ab74970c507d89d78. * 20/4 hz * 25 times, just like old times * god damn slow it down * faster * a tad bit faster * slower at the end * Volkswagen * more checks * log vw customs stock long * change it up * change it up for vw checks * oops * make sure it sends 10 times before changing to another button sets * unnecessary * use different count * better logic * bring back speed_diff * vw: faster * chrysler support * mazda support * fixup! chrysler support * bump panda * bump panda * fix upstream merge * Enable for Mazda * initial and lowest set speed for all supported brands * use buttonEvents from carstate for FCA and Mazda * gate this behind non PCM only * lower calls * fix counter in button send * log FCA and Mazda * format * just send one copy * FCA: make SET+ set instead of resume * Nicki Minaj Model (commaai#28218) * New model: 2ff7490f-8a2f-4c0d-87a8-b0fa3a4a6a71 * Updated model_replay_ref_commit (cherry picked from commit 328b5d9) * Revert "FCA: make SET+ set instead of resume" This reverts commit 523a0537b728e8243e9cecb47169799d519aac3f. * try this out * try to match jvepilot's logic * send with extra incrementing counts * Revert "Revert "FCA: make SET+ set instead of resume"" This reverts commit f414a51e784b040d0f04881adcfc78d7faacda2a. * have to block it * lower send at 4 Hz * can't be int * 10 Hz max, 1 copy * mazda send at 10 Hz * chrysler at 10 hz * send at 10 Hz * remove this check for vw for now * hkg can-fd go back to 4Hz, 1 copy * hkg can-fd go back to 5Hz, 1 copy * vw: different send freq logic * Set cruise button every frame for FCA and HKG * Set cruise button every frame for Mazda * Revert "Set cruise button every frame for HKG" * can't use brackets * FCA: only send if counter has changed * HKG CAN-FD: only send if counter has changed * only up button frame if needed * Revert "Set cruise button every frame for FCA" * HKG CAN-FD: fix name * FCA: handle resume button press engage cruisestate enabled * FCA: separate RAM and non-RAM * bump panda (test CAN Bus Disconnected bad commit) * bump panda * bump panda * Revert "Nicki Minaj Model (commaai#28218)" This reverts commit 348f68b68c0bd2fcb6fdd6269e911d63ada968b4. * gate behind customStockLong --------- Co-authored-by: Mitchell Goff <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.