Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lexus IS Series Compatibility #287

Closed
kushal-jaisingh opened this issue Jul 12, 2018 · 8 comments
Closed

Lexus IS Series Compatibility #287

kushal-jaisingh opened this issue Jul 12, 2018 · 8 comments

Comments

@kushal-jaisingh
Copy link

I noticed that none of the Lexus IS series vehicles are included on the compatibility list on the github readme. However, it does have adaptive cruise control and lane keep assist. That being said, is openpilot currently compatible with the 2018 Lexus IS-350? If so, any reviews how well it works? I was searching for some video reviews of openpilot and most of them were great. However, out of all the reviews I managed to find, there was only 1 review for a Lexus vehicle (the RX series), and in the video they noted that for some reason the car would keep hugging the right shoulder of the road. That being said, has this issue been resolved and how is the compatibility with other Lexus vehicles specifically the 2018 IS-350? Thanks

@thomaspich
Copy link

Hi @kushal-jaisingh ! It must be compatible, I have ported OpenPilot on a 2018 Lexus (CT200h)

@adeebshihadeh
Copy link
Contributor

My fork should work but might need to change the fingerprint. Join the discord if you need help. https://discord.comma.ai/

@Mason0916
Copy link

Mason0916 commented Aug 26, 2019

嗨@ kushal-jaisingh!它必須兼容,我已經在2018年雷克薩斯(CT200h)上移植了OpenPilot

Hi @thomaspich 2018 CT200H Can it be used normally?

@eFiniLan
Copy link
Contributor

@Mason0916 CT200H 已經有 PR 給官版了,在沒整合進官版前可以找第三方的版本安裝

@thomaspich
Copy link

Hi @Mason0916, I made a pull request on comma's branch, normally this should be merged in the next releases. If you want to have Openpilot on your CT200h now, just clone my repo https://github.com/thomaspich/openpilot and git checkout on lexus-ct200h-port branch

@Mason0916
Copy link

嗨@ Mason0916,我在逗號的分支上發出了拉取請求,通常這應該在下一個版本中合併。如果你想在CT200h上安裝Openpilot,只需克隆我的repo https://github.com/thomaspich/openpilot和git checkout on lexus-ct200h-port分支

I am a Ct200H owner, the original ACC can only start at speed above 45, Openpilot can follow the car to speed 0? The original LDA is also used at speeds of more than 50 kilometers per hour. Is it necessary to dismantle the original computer?

@thomaspich
Copy link

@Mason0916 When you don't have disconnected your DSU (which does ACC) you can enable OpenPilot only above 45kph, and it stops at 40kph. The LDA works until 40kph too, because OpenPilot does it.
Have you see how to install the EON ? It's pretty easy ! Just disconnect the FRC cable and plug the giraffe in the middle
Are you on Discord ? It's easier to talk on it with my phone

@rbiasini
Copy link
Contributor

Lexus IS is fully supported since 0.6.4 openpilot release.

pd0wm pushed a commit that referenced this issue Oct 9, 2019
30c7ca8 bump version to 1.5.3
9403dbe Need to fix wifi test before re-enabling.
0812362 GPS UART fix until boardd is refactored (#294)
ffbdb87 python2 -> 3 fixes to pedal flasher (#292)
78b75ef Added build type to release version strings
736c2cb Fixed sending of bytes over PandaSerial
0894b28 Fixed USB power mode on black (#291)
4b3358c patch to be able to switch from EON to PC with a Panda that has EON b… (#290)
a95c44a Made setting of NOOUTPUT on no heartbeat more efficient (#287)
9486836 UART instability fix with high interrupt load (#283)
9a9e9d4 Fix usb_power_mode missing initialization (#289)
af0960a DFU fix (#288)
70219d7 match safety enum in cereal (#285)
a338d39 Fix build for jenkins test
78ef4a6 Stop charge (#284)
5266a40 Fix typo (#286)
f4787ec Revert "turn on CDP when ignition switches on (#281)"
d37daee Revert "NONE and CLIENT should be the same thing in white/grey pandas"
e97b283 NONE and CLIENT should be the same thing in white/grey pandas
8c1df55 turn on CDP when ignition switches on (#281)
847a35d Fix bullet points
fac0277 Misra update (#280)
5a04df6 Added description of regression tests to README
c4aabae Fixed some python3 bugs in the test scripts and PandaSerial
9af0cb3 Bump version
c4ac3d6 Disable GPS load switching on black pandas
078ee58 This is the correct table, actually
578b95e Misra table of coverage added
d383a26 bump panda
b98ca01 fix sdk build in python3 env (#279)
63d3dc7 Set python3 env before runnign get_sdk, so we know if it fails
e951d79 legacy code we don't control can remain python2
11b7151 Merge pull request #276 from commaai/python3
9893a84 Merge pull request #277 from zorrobyte/patch-1
d326869 Revert "revert back esptool to python2 and force to build esptools with python2"
875e760 revert back esptool to python2 and force to build esptools with python2
9c40e62 needed to install python3
ed2ac87 Also moved safety tests to python3
6842b2d move esptool sdk installation before python3 env is set. Kind of a cheat
b5a2cab this hopefully fixes build test
6280509 Fixes safety replay
2c220b6 this fixes language regr test
fdbe789 use python 3 in Docker container
ee1ae4f Better hash print
0de9ef7 Revert "Final 2to3 on the whole repo"
c92fd3b Final 2to3 on the whole repo
5f2bc44 better
b2a30fd make works!
b74005d fix sign.py
fe72770 read file as byte and no tab before sleep
32a344e Update README.md
2dc3409 2to3 applied
ffa68ef undo unnecessary brackets for print
dbc2480 Fix all the prints with 2to3, some need to be undo
5a7aeba xrange is gone
982c4c9 one more python3 env
1e2412a env python -> env python3

git-subtree-dir: panda
git-subtree-split: 30c7ca8
jyoung8607 pushed a commit to jyoung8607/openpilot that referenced this issue Oct 10, 2019
30c7ca8 bump version to 1.5.3
9403dbe Need to fix wifi test before re-enabling.
0812362 GPS UART fix until boardd is refactored (commaai#294)
ffbdb87 python2 -> 3 fixes to pedal flasher (commaai#292)
78b75ef Added build type to release version strings
736c2cb Fixed sending of bytes over PandaSerial
0894b28 Fixed USB power mode on black (commaai#291)
4b3358c patch to be able to switch from EON to PC with a Panda that has EON b… (commaai#290)
a95c44a Made setting of NOOUTPUT on no heartbeat more efficient (commaai#287)
9486836 UART instability fix with high interrupt load (commaai#283)
9a9e9d4 Fix usb_power_mode missing initialization (commaai#289)
af0960a DFU fix (commaai#288)
70219d7 match safety enum in cereal (commaai#285)
a338d39 Fix build for jenkins test
78ef4a6 Stop charge (commaai#284)
5266a40 Fix typo (commaai#286)
f4787ec Revert "turn on CDP when ignition switches on (commaai#281)"
d37daee Revert "NONE and CLIENT should be the same thing in white/grey pandas"
e97b283 NONE and CLIENT should be the same thing in white/grey pandas
8c1df55 turn on CDP when ignition switches on (commaai#281)
847a35d Fix bullet points
fac0277 Misra update (commaai#280)
5a04df6 Added description of regression tests to README
c4aabae Fixed some python3 bugs in the test scripts and PandaSerial
9af0cb3 Bump version
c4ac3d6 Disable GPS load switching on black pandas
078ee58 This is the correct table, actually
578b95e Misra table of coverage added
d383a26 bump panda
b98ca01 fix sdk build in python3 env (commaai#279)
63d3dc7 Set python3 env before runnign get_sdk, so we know if it fails
e951d79 legacy code we don't control can remain python2
11b7151 Merge pull request commaai#276 from commaai/python3
9893a84 Merge pull request commaai#277 from zorrobyte/patch-1
d326869 Revert "revert back esptool to python2 and force to build esptools with python2"
875e760 revert back esptool to python2 and force to build esptools with python2
9c40e62 needed to install python3
ed2ac87 Also moved safety tests to python3
6842b2d move esptool sdk installation before python3 env is set. Kind of a cheat
b5a2cab this hopefully fixes build test
6280509 Fixes safety replay
2c220b6 this fixes language regr test
fdbe789 use python 3 in Docker container
ee1ae4f Better hash print
0de9ef7 Revert "Final 2to3 on the whole repo"
c92fd3b Final 2to3 on the whole repo
5f2bc44 better
b2a30fd make works!
b74005d fix sign.py
fe72770 read file as byte and no tab before sleep
32a344e Update README.md
2dc3409 2to3 applied
ffa68ef undo unnecessary brackets for print
dbc2480 Fix all the prints with 2to3, some need to be undo
5a7aeba xrange is gone
982c4c9 one more python3 env
1e2412a env python -> env python3

git-subtree-dir: panda
git-subtree-split: 30c7ca8
jyoung8607 pushed a commit to jyoung8607/openpilot that referenced this issue Nov 6, 2019
30c7ca8 bump version to 1.5.3
9403dbe Need to fix wifi test before re-enabling.
0812362 GPS UART fix until boardd is refactored (commaai#294)
ffbdb87 python2 -> 3 fixes to pedal flasher (commaai#292)
78b75ef Added build type to release version strings
736c2cb Fixed sending of bytes over PandaSerial
0894b28 Fixed USB power mode on black (commaai#291)
4b3358c patch to be able to switch from EON to PC with a Panda that has EON b… (commaai#290)
a95c44a Made setting of NOOUTPUT on no heartbeat more efficient (commaai#287)
9486836 UART instability fix with high interrupt load (commaai#283)
9a9e9d4 Fix usb_power_mode missing initialization (commaai#289)
af0960a DFU fix (commaai#288)
70219d7 match safety enum in cereal (commaai#285)
a338d39 Fix build for jenkins test
78ef4a6 Stop charge (commaai#284)
5266a40 Fix typo (commaai#286)
f4787ec Revert "turn on CDP when ignition switches on (commaai#281)"
d37daee Revert "NONE and CLIENT should be the same thing in white/grey pandas"
e97b283 NONE and CLIENT should be the same thing in white/grey pandas
8c1df55 turn on CDP when ignition switches on (commaai#281)
847a35d Fix bullet points
fac0277 Misra update (commaai#280)
5a04df6 Added description of regression tests to README
c4aabae Fixed some python3 bugs in the test scripts and PandaSerial
9af0cb3 Bump version
c4ac3d6 Disable GPS load switching on black pandas
078ee58 This is the correct table, actually
578b95e Misra table of coverage added
d383a26 bump panda
b98ca01 fix sdk build in python3 env (commaai#279)
63d3dc7 Set python3 env before runnign get_sdk, so we know if it fails
e951d79 legacy code we don't control can remain python2
11b7151 Merge pull request commaai#276 from commaai/python3
9893a84 Merge pull request commaai#277 from zorrobyte/patch-1
d326869 Revert "revert back esptool to python2 and force to build esptools with python2"
875e760 revert back esptool to python2 and force to build esptools with python2
9c40e62 needed to install python3
ed2ac87 Also moved safety tests to python3
6842b2d move esptool sdk installation before python3 env is set. Kind of a cheat
b5a2cab this hopefully fixes build test
6280509 Fixes safety replay
2c220b6 this fixes language regr test
fdbe789 use python 3 in Docker container
ee1ae4f Better hash print
0de9ef7 Revert "Final 2to3 on the whole repo"
c92fd3b Final 2to3 on the whole repo
5f2bc44 better
b2a30fd make works!
b74005d fix sign.py
fe72770 read file as byte and no tab before sleep
32a344e Update README.md
2dc3409 2to3 applied
ffa68ef undo unnecessary brackets for print
dbc2480 Fix all the prints with 2to3, some need to be undo
5a7aeba xrange is gone
982c4c9 one more python3 env
1e2412a env python -> env python3

git-subtree-dir: panda
git-subtree-split: 30c7ca8
Vaggysag pushed a commit to Vaggysag/openpilot that referenced this issue Apr 21, 2020
* Made setting of NOOUTPUT on no heartbeat more efficient

* Stupid mistake

* Fixed hardcoded safety mode
mattbsea pushed a commit to mattbsea/openpilot that referenced this issue Dec 3, 2020
* Update interface.py

Needs safetyparam 53. Needs op edit param for new name. This tune was created as a colab with cgw. I cant test it but he enjoys it very much.

* Update interface.py

Removed safety param

* Update interface.py

Safetyparam 56

* Update interface.py

* Update op_params.py

* Update interface.py

* missing comma

* just desc. changes

* Update interface.py

Co-authored-by: SCshredder17 <[email protected]>
Co-authored-by: Shane Smiskol <[email protected]>
nworb-cire pushed a commit to opgm/openpilot that referenced this issue Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants