Temporarily revert v0.6.7 changes #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0c9484c.
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
sergio-mena
approved these changes
Jan 12, 2023
| @@ -25,7 +25,7 @@ func NewBadgerDB(dbName, dir string) (*BadgerDB, error) { | |||
| // the final directory to use for the database. | |||
| path := filepath.Join(dir, dbName) | |||
|
|
|||
| if err := os.MkdirAll(path, 0o755); err != nil { | |||
There was a problem hiding this comment.
Are we sure about this change?
Last time I was something similar was (I think) in one of Jacob's PR's, but his change also came with a change in the library used.
There was a problem hiding this comment.
The 0o755 -> 0755 change? If so, it's just a convention automatically set by the formatter. There are 3 different formats for octal literals that mean the same thing according to the Go spec: https://go.dev/ref/spec#Integer_literals
There was a problem hiding this comment.
My current plan is to clean up the repo prior to cutting a v0.6.8 release so as to update the linter config, etc. to harmonize with what we have in the CometBFT repo.
Signed-off-by: Thane Thomson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8
This is unfortunately not a simple revert, but it reverts all of the core logic/dependency changes after the v0.6.6 release.