Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e istio crd; deprecated apiextensions/v1beta1 (#1740) #23

Closed
wants to merge 5 commits into from

Conversation

noam-codefresh
Copy link

cherry-picked argoproj#1740 from upstream/master into our fork

Signed-off-by: Hui Kang [email protected]
Signed-off-by: Noam Gal [email protected]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@noam-codefresh noam-codefresh self-assigned this Jan 6, 2022
@codecov
Copy link

codecov bot commented Jan 6, 2022

Codecov Report

Merging #23 (b8310fa) into release-1.1 (cac8a9f) will decrease coverage by 0.00%.
The diff coverage is 84.42%.

Impacted file tree graph

@@               Coverage Diff               @@
##           release-1.1      #23      +/-   ##
===============================================
- Coverage        81.76%   81.75%   -0.01%     
===============================================
  Files              112      113       +1     
  Lines            15117    15542     +425     
===============================================
+ Hits             12360    12707     +347     
- Misses            2110     2174      +64     
- Partials           647      661      +14     
Impacted Files Coverage Δ
rollout/trafficrouting.go 69.43% <62.40%> (-8.76%) ⬇️
rollout/trafficrouting/nginx/nginx.go 80.19% <75.94%> (-5.62%) ⬇️
utils/ingress/wrapper.go 89.25% <89.25%> (ø)
rollout/trafficrouting/alb/alb.go 84.00% <92.85%> (-0.87%) ⬇️
ingress/alb.go 96.25% <100.00%> (+0.47%) ⬆️
ingress/ingress.go 60.60% <100.00%> (+0.40%) ⬆️
.../apis/rollouts/validation/validation_references.go 84.58% <100.00%> (ø)
rollout/controller.go 74.66% <100.00%> (-0.63%) ⬇️
utils/ingress/ingress.go 100.00% <100.00%> (ø)
rollout/canary.go 74.49% <0.00%> (-2.03%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac8a9f...b8310fa. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants