Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e istio crd; deprecated apiextensions/v1beta1 #1740

Merged
merged 3 commits into from
Jan 4, 2022

Conversation

huikang
Copy link
Member

@huikang huikang commented Jan 3, 2022

Signed-off-by: Hui Kang [email protected]

close #1739

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@huikang huikang requested a review from jessesuen January 3, 2022 15:51
@huikang huikang force-pushed the 1739-e2e-istio-crd branch from efba4cb to 02b0001 Compare January 3, 2022 16:08
Signed-off-by: Hui Kang <[email protected]>
@huikang huikang force-pushed the 1739-e2e-istio-crd branch from c1965b0 to cdd3114 Compare January 3, 2022 16:28
@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #1740 (7bf35ee) into master (a3477cf) will not change coverage.
The diff coverage is n/a.

❗ Current head 7bf35ee differs from pull request most recent head 149c40f. Consider uploading reports for the commit 149c40f to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1740   +/-   ##
=======================================
  Coverage   82.02%   82.02%           
=======================================
  Files         116      116           
  Lines       16096    16096           
=======================================
  Hits        13203    13203           
  Misses       2218     2218           
  Partials      675      675           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3477cf...149c40f. Read the comment docs.

@huikang huikang force-pushed the 1739-e2e-istio-crd branch 7 times, most recently from 7bf35ee to 4c35845 Compare January 4, 2022 01:48
- e2e uses networkv1.ingress

Signed-off-by: Hui Kang <[email protected]>
@huikang huikang force-pushed the 1739-e2e-istio-crd branch from 4c35845 to 149c40f Compare January 4, 2022 02:15
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@huikang
Copy link
Member Author

huikang commented Jan 4, 2022

Hi, @jessesuen , the e2e succeeded once and then failed due to a flaky test. Could you take a look this PR? Thanks.

@harikrongali harikrongali self-requested a review January 4, 2022 03:23
@jessesuen jessesuen merged commit 04494ef into argoproj:master Jan 4, 2022
noam-codefresh pushed a commit to codefresh-io/argo-rollouts that referenced this pull request Jan 6, 2022
noam-codefresh pushed a commit to codefresh-io/argo-rollouts that referenced this pull request Feb 9, 2022
danielm-codefresh pushed a commit to codefresh-io/argo-rollouts that referenced this pull request Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

e2e test failed due to deprecated kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1beta1"
3 participants