-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FYST-1778 MD wants more bank info in financial resolution on xml #5566
Merged
arinchoi03
merged 8 commits into
main
from
FYST-1778-md-update-financial-resolution-on-xml
Feb 12, 2025
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e6492f3
Add FirstInput banking information to Authentication Header
arinchoi03 e9df128
Refactor
arinchoi03 fd24f1b
Only fill out FirstInput if all parts are present
arinchoi03 ef304d9
Add logic to only fill this FirstInput section if direct_deposit chos…
arinchoi03 506e1cf
test that even for md with refund/owed the banking info doesnt fill o…
arinchoi03 ea29f3e
Update app/lib/submission_builder/authentication_header.rb
arinchoi03 fdfd6f4
Explicitly set payment method
arinchoi03 488e0c6
Merge remote-tracking branch 'origin' into FYST-1778-md-update-financ…
arinchoi03 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,14 +2,17 @@ | |
|
||
describe SubmissionBuilder::FinancialTransaction do | ||
describe '.build' do | ||
let(:intake) { create(:state_file_az_owed_intake) } | ||
let(:kwargs) { {} } | ||
let(:submission) { create(:efile_submission, data_source: intake) } | ||
let(:xml) { | ||
Nokogiri::XML::Document.parse( | ||
described_class.build( | ||
submission, validate: false, kwargs: kwargs | ||
).document.to_xml) | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. refactored tests in FinancialTransaction (I was here accidentally, thought I was adding stuff here but turned out i was supposed to be adding to AuthenticationHeader 😓) |
||
context "when filer owes money" do | ||
let(:intake) { create(:state_file_az_owed_intake) } | ||
let(:submission) { create(:efile_submission, data_source: intake) } | ||
it "populates the StatePayment" do | ||
xml = Nokogiri::XML::Document.parse( | ||
described_class.build( | ||
submission, validate: false | ||
).document.to_xml) | ||
expect(xml.at("StatePayment Checking").text).to eq "X" | ||
expect(xml.at("StatePayment RoutingTransitNumber").text).to eq "111111111" | ||
expect(xml.at("StatePayment BankAccountNumber").text).to eq "222222222" | ||
|
@@ -29,10 +32,6 @@ | |
let(:intake) { create(:state_file_nc_intake, :taxes_owed) } | ||
|
||
it "populates the StatePayment with additional information" do | ||
xml = Nokogiri::XML::Document.parse( | ||
described_class.build( | ||
submission, validate: false | ||
).document.to_xml) | ||
expect(xml.at("StatePayment Checking").text).to eq "X" | ||
expect(xml.at("StatePayment RoutingTransitNumber").text).to eq "111111111" | ||
expect(xml.at("StatePayment BankAccountNumber").text).to eq "222222222" | ||
|
@@ -53,12 +52,9 @@ | |
context "when filer gets a refund" do | ||
let(:intake) { create(:state_file_az_refund_intake) } | ||
let(:submission) { create(:efile_submission, data_source: intake) } | ||
let(:kwargs) { { refund_amount: 5 } } | ||
|
||
it "populates the RefundDirectDeposit" do | ||
xml = Nokogiri::XML::Document.parse( | ||
described_class.build( | ||
submission, validate: false, kwargs: { refund_amount: 5 } | ||
).document.to_xml) | ||
expect(xml.at("RefundDirectDeposit Savings").text).to eq "X" | ||
expect(xml.at("RefundDirectDeposit RoutingTransitNumber").text).to eq "111111111" | ||
expect(xml.at("RefundDirectDeposit BankAccountNumber").text).to eq "222222222" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
found the
strftime
format needed to satisfy xsd schema https://apidock.com/ruby/DateTime/strftime