FYST-1778 MD wants more bank info in financial resolution on xml #5566
Conversation
|
Heroku app: https://gyr-review-app-5566-1031c436f04a.herokuapp.com/ |
…en (routing num, acct num, signature should exist at this point)
…ut in FinancialResolution unless direct_deposit payment indicated
| described_class.build( | ||
| submission, validate: false, kwargs: kwargs | ||
| ).document.to_xml) | ||
| } |
There was a problem hiding this comment.
refactored tests in FinancialTransaction (I was here accidentally, thought I was adding stuff here but turned out i was supposed to be adding to AuthenticationHeader 😓)
| xml.FirstInput do | ||
| xml.RoutingTransitNum sanitize_for_xml(@intake.routing_number) if @intake.routing_number.present? | ||
| xml.DepositorAccountNum sanitize_for_xml(@intake.account_number) if @intake.account_number.present? | ||
| xml.InputTimestamp @intake.primary_esigned_at.in_time_zone(StateFile::StateInformationService.timezone("md")).strftime("%FT%T%:z") if @intake.primary_esigned_at.present? |
There was a problem hiding this comment.
found the strftime format needed to satisfy xsd schema https://apidock.com/ruby/DateTime/strftime
arinchoi03
changed the title
| @@ -7,6 +7,13 @@ def document | |||
| build_xml_doc("AuthenticationHeader") do |xml| | |||
| xml.FilingLicenseTypeCd "O" | |||
| xml.FinancialResolution do | |||
| if @intake.has_banking_information_in_financial_resolution? && @intake.payment_or_deposit_type == "direct_deposit" | |||
There was a problem hiding this comment.
thought of checking whether routing/account/signed at exists here (b/c all those are required if FirstInput is present -- but felt like direct_deposit check was enough to ensure those things would be present (routing/acct no) and we should have the esigned_at at this point...but if we want to check all of them I won't be mad about it
| context "refund" do | ||
| let(:intake) { create(:state_file_md_refund_intake, primary_esigned_at: DateTime.new(2025, 2, 15, 12).in_time_zone(StateFile::StateInformationService.timezone("md"))) } | ||
|
|
||
| it "fills out the FirstInput banking information" do |
There was a problem hiding this comment.
should there be another context here specifying payment_or_deposit_type is direct_deposit?
There was a problem hiding this comment.
ooh :state_file_md_refund_intake sets payment_or_deposit_type to direct_deposit but I can explicitly set it
| context "owed" do | ||
| let(:intake) { create(:state_file_md_owed_intake, primary_esigned_at: DateTime.new(2025, 2, 15, 12).in_time_zone(StateFile::StateInformationService.timezone("md"))) } | ||
|
|
||
| it "fills out the FirstInput banking information" do |
Co-authored-by: em barnard-shao <[email protected]>
…ial-resolution-on-xml
arinchoi03
deleted the
FYST-1778-md-update-financial-resolution-on-xml
branch
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
direct_depositfor either refund OR owed situation but only for MDHow to test?
Screenshots (for visual changes)