Changing use of >= IE9 dependent array map method to use jQuery map meth... #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethod for IE8 support since jQuery is already a dependency.
|
Any word on this? Why is this an issue to merge in? |
|
@dlabey: Thank you..! |
codef0rmer
pushed a commit
that referenced
this pull request
Dec 21, 2014
…enamed with jQuery.noConflict()
codef0rmer
pushed a commit
that referenced
this pull request
Jan 4, 2015
- fix(README): Closes #108 and [cleanup](7c06a61) - fix(*): Closes #102 - use $.map over native .map method for IE8 - fix(*): Closes #137 - drag/drop should work even when compile-time debugging is disabled - fix(*): Closes #130 - avoid setting display: block on dropped cell - fix(*): Closes #102 - passing global jQuery reference in case it is renamed with jQuery.noConflict() - fix(*): Closes #143 - introduce deepCopy option to support deep copy on draggable/droppable - perf(*): Undo #55 because some callbacks are performance intensive, especially, onDrag, to run a digest loop for. Call $scope.$apply() within the callback if needed - fix(*): Closes #144 - default or custom confirmation before drop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...od for IE8 support since jQuery is already a dependency.
Hi all, since map is a method native to browsers >= IE9 and jQuery is already a dependency on this project, I thought it was useful to use the jQuery map method instead so IE8 can take advantage of this library in Angular 1.2 and below.