Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work when compile-time debugging is disabled #137

Closed
michal-filip opened this issue Nov 10, 2014 · 1 comment
Closed

Does not work when compile-time debugging is disabled #137

michal-filip opened this issue Nov 10, 2014 · 1 comment

Comments

@michal-filip
Copy link

Apparently, then compilation-time debugging is disabled in angular (recommended in production), the directives stop working because they rely on a missing function for getting element's scope.

This only causes trouble if this kind of code is used:

.config(['$compileProvider', function ($compileProvider) {
        $compileProvider.debugInfoEnabled(false);
    }])

See:
https://github.com/codef0rmer/angular-dragdrop/blob/master/src/angular-dragdrop.js#L71
angular/angular.js#9515

codef0rmer pushed a commit that referenced this issue Jan 4, 2015
  - fix(README): Closes #108 and [cleanup](7c06a61)
  - fix(*): Closes #102 - use $.map over native .map method for IE8
  - fix(*): Closes #137 - drag/drop should work even when compile-time debugging is disabled
  - fix(*): Closes #130 - avoid setting display: block on dropped cell
  - fix(*): Closes #102 - passing global jQuery reference in case it is renamed with jQuery.noConflict()
  - fix(*): Closes #143 - introduce deepCopy option to support deep copy on draggable/droppable
  - perf(*): Undo #55 because some callbacks are performance intensive, especially, onDrag, to run a digest loop for. Call $scope.$apply() within the callback if needed
  - fix(*): Closes #144 - default or custom confirmation before drop
@hdi-amiri
Copy link

this issue is not solved I guess, any solution for it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants