Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: include range key stats in ScanStats #94345

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

jbowens
Copy link
Collaborator

@jbowens jbowens commented Dec 27, 2022

Include the new, low-level Pebble range key iterator stats (introduced in cockroachdb/pebble#1871) in roachpb.ScanStats.

Informs #77580.
Close #93326.

Epic: None
Release note: None

Include the new, low-level Pebble range key iterator stats (introduced in
cockroachdb/pebble#1871) in roachpb.ScanStats.

Informs cockroachdb#77580.
Close cockroachdb#93326.

Epic: None
Release note: None
@jbowens jbowens requested review from a team as code owners December 27, 2022 22:20
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@jbowens jbowens self-assigned this Dec 27, 2022
Copy link
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 22.2 backport?

@jbowens
Copy link
Collaborator Author

jbowens commented Jan 3, 2023

TFTR!

bors r=erikgrinaker

@craig
Copy link
Contributor

craig bot commented Jan 3, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

storage: include range key info in ScanStats
3 participants