storage: include range key info in ScanStats
#93326
Assignees
Labels
A-storage
Relating to our storage engine (Pebble) on-disk storage.
C-enhancement
Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception)
T-storage
Storage Team
Comments
erikgrinaker
added
C-enhancement
blathers-crl
bot
added
the
A-storage
|
I have a PR (cockroachdb/pebble#1871) that's been languishing. I'll try to get it across the finish line next week. |
craig bot
pushed a commit
that referenced
this issue
Jan 3, 2023
94010: sql/importer: unskip TestCSVImportCanBeResumed r=rafiss a=stevendanna This unskips the test and adds a memory limit. The test completed 1500+ runs under stress. I believe #93782 resolved the main source of flakiness here. Fixes #91828 Release note: None 94345: storage: include range key stats in ScanStats r=erikgrinaker a=jbowens Include the new, low-level Pebble range key iterator stats (introduced in cockroachdb/pebble#1871) in roachpb.ScanStats. Informs #77580. Close #93326. Epic: None Release note: None 94458: logictest: fix flakes from mixed version testing r=ZhouXing19 a=rafiss fixes #92637 The main fix was to wait for each node to be reachable before beginning the upgrade process. This also includes a version bump that has better logging to make it easier to debug. Release note: None Co-authored-by: Steven Danna <[email protected]> Co-authored-by: Jackson Owens <[email protected]> Co-authored-by: Rafi Shamim <[email protected]>
blathers-crl bot
pushed a commit
that referenced
this issue
Jan 3, 2023
Include the new, low-level Pebble range key iterator stats (introduced in cockroachdb/pebble#1871) in roachpb.ScanStats. Informs #77580. Close #93326. Epic: None Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
roachpb.ScanStatsstruct contains scan statistics that are attached to BatchResponses for observability purposes. This should include information about range keys as well, which will require corresponding changes topebble.IteratorStats.cockroach/pkg/storage/mvcc.go
Lines 3556 to 3559 in 19f2fad
Jira issue: CRDB-22275
The text was updated successfully, but these errors were encountered: