rowexec: close all ValueGenerators in the project set processor #86964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we forgot to close the value generators when a new input row is read by the project set processor which could lead to leaking of the resources. This is now fixed. Most of the value generators don't need to release any resources, a few need to close their memory account (previously this would result in a sentry report, but no actual leak would occur in production builds), the only concerning one is `crdb_internal.payloads_for_trace` where we would not close the `InternalRows` iterator. But that seems like an internal debugging tool, so most likely the users weren't impacted. Release justification: bug fix. Release note: None (It seems like in most cases the users would not see the impact.)
|
This change is |
michae2
approved these changes
Aug 26, 2022
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball)
|
TFTR! bors r+ |
|
Build succeeded: |
This was referenced Aug 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we forgot to close the value generators when a new input row
is read by the project set processor which could lead to leaking of the
resources. This is now fixed. Most of the value generators don't need to
release any resources, a few need to close their memory account
(previously this would result in a sentry report, but no actual leak
would occur in production builds), the only concerning one is
crdb_internal.payloads_for_tracewhere we would not close theInternalRowsiterator. But that seems like an internal debugging tool,so most likely the users weren't impacted.
Fixes: #85418.
Release justification: bug fix.
Release note: None (It seems like in most cases the users would not see
the impact.)