outliers: rename to insights

pkg/BUILD.bazel

@@ -419,8 +419,8 @@ ALL_TESTS = [
     "//pkg/sql/sqlinstance/instancestorage:instancestorage_test",
     "//pkg/sql/sqlliveness/slinstance:slinstance_test",
     "//pkg/sql/sqlliveness/slstorage:slstorage_test",
-    "//pkg/sql/sqlstats/outliers/integration:integration_test",
-    "//pkg/sql/sqlstats/outliers:outliers_test",
+    "//pkg/sql/sqlstats/insights/integration:integration_test",
+    "//pkg/sql/sqlstats/insights:insights_test",
     "//pkg/sql/sqlstats/persistedsqlstats/sqlstatsutil:sqlstatsutil_test",
     "//pkg/sql/sqlstats/persistedsqlstats:persistedsqlstats_test",
     "//pkg/sql/sqlstats/sslocal:sslocal_test",
@@ -1582,9 +1582,9 @@ GO_TARGETS = [
     "//pkg/sql/sqlliveness/slstorage:slstorage_test",
     "//pkg/sql/sqlliveness/sqllivenesstestutils:sqllivenesstestutils",
     "//pkg/sql/sqlliveness:sqlliveness",
-    "//pkg/sql/sqlstats/outliers/integration:integration_test",
-    "//pkg/sql/sqlstats/outliers:outliers",
-    "//pkg/sql/sqlstats/outliers:outliers_test",
+    "//pkg/sql/sqlstats/insights/integration:integration_test",
+    "//pkg/sql/sqlstats/insights:insights",
+    "//pkg/sql/sqlstats/insights:insights_test",
     "//pkg/sql/sqlstats/persistedsqlstats/sqlstatsutil:sqlstatsutil",
     "//pkg/sql/sqlstats/persistedsqlstats/sqlstatsutil:sqlstatsutil_test",
     "//pkg/sql/sqlstats/persistedsqlstats:persistedsqlstats",
@@ -2551,8 +2551,8 @@ GET_X_DATA_TARGETS = [
     "//pkg/sql/sqlliveness/slstorage:get_x_data",
     "//pkg/sql/sqlliveness/sqllivenesstestutils:get_x_data",
     "//pkg/sql/sqlstats:get_x_data",
-    "//pkg/sql/sqlstats/outliers:get_x_data",
-    "//pkg/sql/sqlstats/outliers/integration:get_x_data",
+    "//pkg/sql/sqlstats/insights:get_x_data",
+    "//pkg/sql/sqlstats/insights/integration:get_x_data",
     "//pkg/sql/sqlstats/persistedsqlstats:get_x_data",
     "//pkg/sql/sqlstats/persistedsqlstats/sqlstatsutil:get_x_data",
     "//pkg/sql/sqlstats/sslocal:get_x_data",

pkg/ccl/logictestccl/testdata/logic_test/crdb_internal_tenant

@@ -75,7 +75,7 @@ crdb_internal  lost_descriptors_with_data       table  NULL  NULL  NULL
 crdb_internal  node_build_info                  table  NULL  NULL  NULL
 crdb_internal  node_contention_events           table  NULL  NULL  NULL
 crdb_internal  node_distsql_flows               table  NULL  NULL  NULL
-crdb_internal  node_execution_outliers          table  NULL  NULL  NULL
+crdb_internal  node_execution_insights          table  NULL  NULL  NULL
 crdb_internal  node_inflight_trace_spans        table  NULL  NULL  NULL
 crdb_internal  node_metrics                     table  NULL  NULL  NULL
 crdb_internal  node_queries                     table  NULL  NULL  NULL

pkg/cli/testdata/zip/partial1

@@ -82,7 +82,7 @@ debug zip --concurrency=1 --cpu-profile-duration=0s /dev/null
 [node 1] retrieving SQL data for crdb_internal.node_build_info... writing output: debug/nodes/1/crdb_internal.node_build_info.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_contention_events... writing output: debug/nodes/1/crdb_internal.node_contention_events.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_distsql_flows... writing output: debug/nodes/1/crdb_internal.node_distsql_flows.txt... done
-[node 1] retrieving SQL data for crdb_internal.node_execution_outliers... writing output: debug/nodes/1/crdb_internal.node_execution_outliers.txt... done
+[node 1] retrieving SQL data for crdb_internal.node_execution_insights... writing output: debug/nodes/1/crdb_internal.node_execution_insights.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_inflight_trace_spans... writing output: debug/nodes/1/crdb_internal.node_inflight_trace_spans.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_metrics... writing output: debug/nodes/1/crdb_internal.node_metrics.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_queries... writing output: debug/nodes/1/crdb_internal.node_queries.txt... done
@@ -190,9 +190,9 @@ debug zip --concurrency=1 --cpu-profile-duration=0s /dev/null
 [node 2] retrieving SQL data for crdb_internal.node_distsql_flows... writing output: debug/nodes/2/crdb_internal.node_distsql_flows.txt...
 [node 2] retrieving SQL data for crdb_internal.node_distsql_flows: last request failed: failed to connect to ...
 [node 2] retrieving SQL data for crdb_internal.node_distsql_flows: creating error output: debug/nodes/2/crdb_internal.node_distsql_flows.txt.err.txt... done
-[node 2] retrieving SQL data for crdb_internal.node_execution_outliers... writing output: debug/nodes/2/crdb_internal.node_execution_outliers.txt...
-[node 2] retrieving SQL data for crdb_internal.node_execution_outliers: last request failed: failed to connect to ...
-[node 2] retrieving SQL data for crdb_internal.node_execution_outliers: creating error output: debug/nodes/2/crdb_internal.node_execution_outliers.txt.err.txt... done
+[node 2] retrieving SQL data for crdb_internal.node_execution_insights... writing output: debug/nodes/2/crdb_internal.node_execution_insights.txt...
+[node 2] retrieving SQL data for crdb_internal.node_execution_insights: last request failed: failed to connect to ...
+[node 2] retrieving SQL data for crdb_internal.node_execution_insights: creating error output: debug/nodes/2/crdb_internal.node_execution_insights.txt.err.txt... done
 [node 2] retrieving SQL data for crdb_internal.node_inflight_trace_spans... writing output: debug/nodes/2/crdb_internal.node_inflight_trace_spans.txt...
 [node 2] retrieving SQL data for crdb_internal.node_inflight_trace_spans: last request failed: failed to connect to ...
 [node 2] retrieving SQL data for crdb_internal.node_inflight_trace_spans: creating error output: debug/nodes/2/crdb_internal.node_inflight_trace_spans.txt.err.txt... done
@@ -264,7 +264,7 @@ debug zip --concurrency=1 --cpu-profile-duration=0s /dev/null
 [node 3] retrieving SQL data for crdb_internal.node_build_info... writing output: debug/nodes/3/crdb_internal.node_build_info.txt... done
 [node 3] retrieving SQL data for crdb_internal.node_contention_events... writing output: debug/nodes/3/crdb_internal.node_contention_events.txt... done
 [node 3] retrieving SQL data for crdb_internal.node_distsql_flows... writing output: debug/nodes/3/crdb_internal.node_distsql_flows.txt... done
-[node 3] retrieving SQL data for crdb_internal.node_execution_outliers... writing output: debug/nodes/3/crdb_internal.node_execution_outliers.txt... done
+[node 3] retrieving SQL data for crdb_internal.node_execution_insights... writing output: debug/nodes/3/crdb_internal.node_execution_insights.txt... done
 [node 3] retrieving SQL data for crdb_internal.node_inflight_trace_spans... writing output: debug/nodes/3/crdb_internal.node_inflight_trace_spans.txt... done
 [node 3] retrieving SQL data for crdb_internal.node_metrics... writing output: debug/nodes/3/crdb_internal.node_metrics.txt... done
 [node 3] retrieving SQL data for crdb_internal.node_queries... writing output: debug/nodes/3/crdb_internal.node_queries.txt... done

pkg/cli/testdata/zip/partial1_excluded

@@ -82,7 +82,7 @@ debug zip /dev/null --concurrency=1 --exclude-nodes=2 --cpu-profile-duration=0
 [node 1] retrieving SQL data for crdb_internal.node_build_info... writing output: debug/nodes/1/crdb_internal.node_build_info.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_contention_events... writing output: debug/nodes/1/crdb_internal.node_contention_events.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_distsql_flows... writing output: debug/nodes/1/crdb_internal.node_distsql_flows.txt... done
-[node 1] retrieving SQL data for crdb_internal.node_execution_outliers... writing output: debug/nodes/1/crdb_internal.node_execution_outliers.txt... done
+[node 1] retrieving SQL data for crdb_internal.node_execution_insights... writing output: debug/nodes/1/crdb_internal.node_execution_insights.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_inflight_trace_spans... writing output: debug/nodes/1/crdb_internal.node_inflight_trace_spans.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_metrics... writing output: debug/nodes/1/crdb_internal.node_metrics.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_queries... writing output: debug/nodes/1/crdb_internal.node_queries.txt... done
@@ -173,7 +173,7 @@ debug zip /dev/null --concurrency=1 --exclude-nodes=2 --cpu-profile-duration=0
 [node 3] retrieving SQL data for crdb_internal.node_build_info... writing output: debug/nodes/3/crdb_internal.node_build_info.txt... done
 [node 3] retrieving SQL data for crdb_internal.node_contention_events... writing output: debug/nodes/3/crdb_internal.node_contention_events.txt... done
 [node 3] retrieving SQL data for crdb_internal.node_distsql_flows... writing output: debug/nodes/3/crdb_internal.node_distsql_flows.txt... done
-[node 3] retrieving SQL data for crdb_internal.node_execution_outliers... writing output: debug/nodes/3/crdb_internal.node_execution_outliers.txt... done
+[node 3] retrieving SQL data for crdb_internal.node_execution_insights... writing output: debug/nodes/3/crdb_internal.node_execution_insights.txt... done
 [node 3] retrieving SQL data for crdb_internal.node_inflight_trace_spans... writing output: debug/nodes/3/crdb_internal.node_inflight_trace_spans.txt... done
 [node 3] retrieving SQL data for crdb_internal.node_metrics... writing output: debug/nodes/3/crdb_internal.node_metrics.txt... done
 [node 3] retrieving SQL data for crdb_internal.node_queries... writing output: debug/nodes/3/crdb_internal.node_queries.txt... done

pkg/cli/testdata/zip/partial2

@@ -82,7 +82,7 @@ debug zip --concurrency=1 --cpu-profile-duration=0 /dev/null
 [node 1] retrieving SQL data for crdb_internal.node_build_info... writing output: debug/nodes/1/crdb_internal.node_build_info.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_contention_events... writing output: debug/nodes/1/crdb_internal.node_contention_events.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_distsql_flows... writing output: debug/nodes/1/crdb_internal.node_distsql_flows.txt... done
-[node 1] retrieving SQL data for crdb_internal.node_execution_outliers... writing output: debug/nodes/1/crdb_internal.node_execution_outliers.txt... done
+[node 1] retrieving SQL data for crdb_internal.node_execution_insights... writing output: debug/nodes/1/crdb_internal.node_execution_insights.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_inflight_trace_spans... writing output: debug/nodes/1/crdb_internal.node_inflight_trace_spans.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_metrics... writing output: debug/nodes/1/crdb_internal.node_metrics.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_queries... writing output: debug/nodes/1/crdb_internal.node_queries.txt... done
@@ -172,7 +172,7 @@ debug zip --concurrency=1 --cpu-profile-duration=0 /dev/null
 [node 3] retrieving SQL data for crdb_internal.node_build_info... writing output: debug/nodes/3/crdb_internal.node_build_info.txt... done
 [node 3] retrieving SQL data for crdb_internal.node_contention_events... writing output: debug/nodes/3/crdb_internal.node_contention_events.txt... done
 [node 3] retrieving SQL data for crdb_internal.node_distsql_flows... writing output: debug/nodes/3/crdb_internal.node_distsql_flows.txt... done
-[node 3] retrieving SQL data for crdb_internal.node_execution_outliers... writing output: debug/nodes/3/crdb_internal.node_execution_outliers.txt... done
+[node 3] retrieving SQL data for crdb_internal.node_execution_insights... writing output: debug/nodes/3/crdb_internal.node_execution_insights.txt... done
 [node 3] retrieving SQL data for crdb_internal.node_inflight_trace_spans... writing output: debug/nodes/3/crdb_internal.node_inflight_trace_spans.txt... done
 [node 3] retrieving SQL data for crdb_internal.node_metrics... writing output: debug/nodes/3/crdb_internal.node_metrics.txt... done
 [node 3] retrieving SQL data for crdb_internal.node_queries... writing output: debug/nodes/3/crdb_internal.node_queries.txt... done

pkg/cli/testdata/zip/testzip

@@ -85,7 +85,7 @@ debug zip --concurrency=1 --cpu-profile-duration=1s /dev/null
 [node 1] retrieving SQL data for crdb_internal.node_build_info... writing output: debug/nodes/1/crdb_internal.node_build_info.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_contention_events... writing output: debug/nodes/1/crdb_internal.node_contention_events.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_distsql_flows... writing output: debug/nodes/1/crdb_internal.node_distsql_flows.txt... done
-[node 1] retrieving SQL data for crdb_internal.node_execution_outliers... writing output: debug/nodes/1/crdb_internal.node_execution_outliers.txt... done
+[node 1] retrieving SQL data for crdb_internal.node_execution_insights... writing output: debug/nodes/1/crdb_internal.node_execution_insights.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_inflight_trace_spans... writing output: debug/nodes/1/crdb_internal.node_inflight_trace_spans.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_metrics... writing output: debug/nodes/1/crdb_internal.node_metrics.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_queries... writing output: debug/nodes/1/crdb_internal.node_queries.txt... done

pkg/cli/testdata/zip/testzip_concurrent

@@ -304,9 +304,9 @@ zip
 [node 1] retrieving SQL data for crdb_internal.node_distsql_flows...
 [node 1] retrieving SQL data for crdb_internal.node_distsql_flows: done
 [node 1] retrieving SQL data for crdb_internal.node_distsql_flows: writing output: debug/nodes/1/crdb_internal.node_distsql_flows.txt...
-[node 1] retrieving SQL data for crdb_internal.node_execution_outliers...
-[node 1] retrieving SQL data for crdb_internal.node_execution_outliers: done
-[node 1] retrieving SQL data for crdb_internal.node_execution_outliers: writing output: debug/nodes/1/crdb_internal.node_execution_outliers.txt...
+[node 1] retrieving SQL data for crdb_internal.node_execution_insights...
+[node 1] retrieving SQL data for crdb_internal.node_execution_insights: done
+[node 1] retrieving SQL data for crdb_internal.node_execution_insights: writing output: debug/nodes/1/crdb_internal.node_execution_insights.txt...
 [node 1] retrieving SQL data for crdb_internal.node_inflight_trace_spans...
 [node 1] retrieving SQL data for crdb_internal.node_inflight_trace_spans: done
 [node 1] retrieving SQL data for crdb_internal.node_inflight_trace_spans: writing output: debug/nodes/1/crdb_internal.node_inflight_trace_spans.txt...
@@ -622,9 +622,9 @@ zip
 [node 2] retrieving SQL data for crdb_internal.node_distsql_flows...
 [node 2] retrieving SQL data for crdb_internal.node_distsql_flows: done
 [node 2] retrieving SQL data for crdb_internal.node_distsql_flows: writing output: debug/nodes/2/crdb_internal.node_distsql_flows.txt...
-[node 2] retrieving SQL data for crdb_internal.node_execution_outliers...
-[node 2] retrieving SQL data for crdb_internal.node_execution_outliers: done
-[node 2] retrieving SQL data for crdb_internal.node_execution_outliers: writing output: debug/nodes/2/crdb_internal.node_execution_outliers.txt...
+[node 2] retrieving SQL data for crdb_internal.node_execution_insights...
+[node 2] retrieving SQL data for crdb_internal.node_execution_insights: done
+[node 2] retrieving SQL data for crdb_internal.node_execution_insights: writing output: debug/nodes/2/crdb_internal.node_execution_insights.txt...
 [node 2] retrieving SQL data for crdb_internal.node_inflight_trace_spans...
 [node 2] retrieving SQL data for crdb_internal.node_inflight_trace_spans: done
 [node 2] retrieving SQL data for crdb_internal.node_inflight_trace_spans: writing output: debug/nodes/2/crdb_internal.node_inflight_trace_spans.txt...
@@ -940,9 +940,9 @@ zip
 [node 3] retrieving SQL data for crdb_internal.node_distsql_flows...
 [node 3] retrieving SQL data for crdb_internal.node_distsql_flows: done
 [node 3] retrieving SQL data for crdb_internal.node_distsql_flows: writing output: debug/nodes/3/crdb_internal.node_distsql_flows.txt...
-[node 3] retrieving SQL data for crdb_internal.node_execution_outliers...
-[node 3] retrieving SQL data for crdb_internal.node_execution_outliers: done
-[node 3] retrieving SQL data for crdb_internal.node_execution_outliers: writing output: debug/nodes/3/crdb_internal.node_execution_outliers.txt...
+[node 3] retrieving SQL data for crdb_internal.node_execution_insights...
+[node 3] retrieving SQL data for crdb_internal.node_execution_insights: done
+[node 3] retrieving SQL data for crdb_internal.node_execution_insights: writing output: debug/nodes/3/crdb_internal.node_execution_insights.txt...
 [node 3] retrieving SQL data for crdb_internal.node_inflight_trace_spans...
 [node 3] retrieving SQL data for crdb_internal.node_inflight_trace_spans: done
 [node 3] retrieving SQL data for crdb_internal.node_inflight_trace_spans: writing output: debug/nodes/3/crdb_internal.node_inflight_trace_spans.txt...

pkg/cli/testdata/zip/testzip_tenant

@@ -107,7 +107,7 @@ debug zip --concurrency=1 --cpu-profile-duration=1s /dev/null
 [node 1] retrieving SQL data for crdb_internal.node_build_info... writing output: debug/nodes/1/crdb_internal.node_build_info.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_contention_events... writing output: debug/nodes/1/crdb_internal.node_contention_events.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_distsql_flows... writing output: debug/nodes/1/crdb_internal.node_distsql_flows.txt... done
-[node 1] retrieving SQL data for crdb_internal.node_execution_outliers... writing output: debug/nodes/1/crdb_internal.node_execution_outliers.txt... done
+[node 1] retrieving SQL data for crdb_internal.node_execution_insights... writing output: debug/nodes/1/crdb_internal.node_execution_insights.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_inflight_trace_spans... writing output: debug/nodes/1/crdb_internal.node_inflight_trace_spans.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_metrics... writing output: debug/nodes/1/crdb_internal.node_metrics.txt... done
 [node 1] retrieving SQL data for crdb_internal.node_queries... writing output: debug/nodes/1/crdb_internal.node_queries.txt... done

pkg/cli/zip_per_node.go

@@ -70,7 +70,7 @@ var debugZipTablesPerNode = []string{
 	"crdb_internal.node_build_info",
 	"crdb_internal.node_contention_events",
 	"crdb_internal.node_distsql_flows",
-	"crdb_internal.node_execution_outliers",
+	"crdb_internal.node_execution_insights",
 	"crdb_internal.node_inflight_trace_spans",
 	"crdb_internal.node_metrics",
 	"crdb_internal.node_queries",

pkg/gen/protobuf.bzl

@@ -47,7 +47,7 @@ PROTOBUF_SRCS = [
   "//pkg/sql/rowenc/rowencpb:rowencpb_go_proto",
   "//pkg/sql/schemachanger/scpb:scpb_go_proto",
   "//pkg/sql/sessiondatapb:sessiondatapb_go_proto",
-  "//pkg/sql/sqlstats/outliers:outliers_go_proto",
+  "//pkg/sql/sqlstats/insights:insights_go_proto",
   "//pkg/sql/sqlstats/persistedsqlstats:persistedsqlstats_go_proto",
   "//pkg/sql/stats:stats_go_proto",
   "//pkg/sql/types:types_go_proto",

pkg/sql/BUILD.bazel

@@ -417,7 +417,7 @@ go_library(
         "//pkg/sql/sqlinstance",
         "//pkg/sql/sqlliveness",
         "//pkg/sql/sqlstats",
-        "//pkg/sql/sqlstats/outliers",
+        "//pkg/sql/sqlstats/insights",
         "//pkg/sql/sqlstats/persistedsqlstats",
         "//pkg/sql/sqlstats/persistedsqlstats/sqlstatsutil",
         "//pkg/sql/sqlstats/sslocal",