outliers: rename to insights #84917
outliers: rename to insights #84917
Conversation
|
This change is |
There was a problem hiding this comment.
Just had one questions, otherwise
Reviewed 40 of 40 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @matthewtodd)
pkg/sql/sqlstats/insights/insights.go line 32 at r1 (raw file):
var LatencyThreshold = settings.RegisterDurationSetting( settings.TenantWritable, "sql.stats.insights.experimental.latency_threshold",
now that you made more tests, should we maybe remove the experimental ?
There was a problem hiding this comment.
TFTR, @maryliag!
Reviewable status:
pkg/sql/sqlstats/insights/insights.go line 32 at r1 (raw file):
Previously, maryliag (Marylia Gutierrez) wrote…
now that you made more tests, should we maybe remove the
experimental?
Yes! I'll be doing that separately (and have more thoughts on naming queued up from Kevin), just wanted to get this mechanical renaming out there.
There was a problem hiding this comment.
Reviewed 40 of 40 files at r1, all commit messages.
Reviewable status:
The UI design that includes outliers also features other insights about sql execution. We will expand this outliers subsystem to support making those insights as well (probably with more detectors, changing the signature / return type of `isOutlier`). Renaming now is the first step in that direction. Release note: None
|
bors r+ |
|
Build succeeded: |
The UI design that includes outliers also features other insights about
sql execution. We will expand this outliers subsystem to support making
those insights as well (probably with more detectors, changing the
signature / return type of
isOutlier). Renaming now is the first stepin that direction.
Release note: None