ccl/sqlproxyccl: remove the idle monitor component #81174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This commit removes the idle monitor component from the sqlproxy as there's no strong use case for it, as discussed. This is currently not being used anywhere on CockroachCloud, and with the connection migration feature, it's unlikely that we will need this. When a pod goes into the draining state, all connections are migrated away to other running pods. Even though the idle monitor may benefit us by terminating idle connections earlier for connections that cannot be migrated, the complexity of maintaining this outweighs the benefits that we get (i.e. being able to shut down a pod earlier; between 1 to 10 minutes rather than waiting until 10 minutes for forceful termination). At the same time, the --drain-timeout flag has been removed from the `mt start-proxy` command as well. Release note: None
jaylim-crl
force-pushed
the
jay/220510-remove-idle-monitor
branch
from
e1a00da to
f713efd
Compare
|
TFTR! bors r=JeffSwenson |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the idle monitor component from the sqlproxy as there's no
strong use case for it, as discussed. This is currently not being used anywhere
on CockroachCloud, and with the connection migration feature, it's unlikely
that we will need this. When a pod goes into the draining state, all
connections are migrated away to other running pods. Even though the idle
monitor may benefit us by terminating idle connections earlier for connections
that cannot be migrated, the complexity of maintaining this outweighs the
benefits that we get (i.e. being able to shut down a pod earlier; between 1 to
10 minutes rather than waiting until 10 minutes for forceful termination). At
the same time, the --drain-timeout flag has been removed from the
mt start-proxycommand as well.Release note: None