sql: add a cluster setting to avoid system config triggers #71910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Oct 25, 2021
arulajmani
approved these changes
Oct 26, 2021
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @postamar and @rafiss)
rafiss
approved these changes
Oct 28, 2021
mgartner
approved these changes
Oct 28, 2021
ajwerner
force-pushed
the
ajwerner/knob-to-disable-system-config-span-gossip
branch
3 times, most recently
from
aa65f7d to
9a85733
Compare
This is intended as a short-term workaround to improve performance in situations of repeated schema changes, like ORM tests. We have a plan to disable the system config trigger altogether in 22.1 with This PR provides a cluster setting which allows schema change transactions to bypass triggerring an update to the system config span. These updates currently drive only the propagation of zone configs to KV and cluster settings. The cluster setting behavior is retained until we address cockroachdb#70566. Release note: None
ajwerner
force-pushed
the
ajwerner/knob-to-disable-system-config-span-gossip
branch
from
9a85733 to
754db5d
Compare
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
Dec 23, 2021
71910: sql: add a cluster setting to avoid system config triggers r=ajwerner a=ajwerner This is intended as a short-term workaround to improve performance in situations of repeated schema changes, like ORM tests. We have a plan to disable the system config trigger altogether in 22.1 with #70560. This PR provides a cluster setting which allows schema change transactions to bypass triggerring an update to the system config span. These updates currently drive only the propagation of zone configs to KV and cluster settings. The cluster setting behavior is retained until we address #70566. We have a history of these sorts of unsafe settings in `kv.raft_log.disable_synchronization_unsafe`. Release note: None Co-authored-by: Andrew Werner <[email protected]>
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended as a short-term workaround to improve performance in
situations of repeated schema changes, like ORM tests.
We have a plan to disable the system config trigger altogether in 22.1 with
#70560.
This PR provides a cluster setting which allows schema change transactions
to bypass triggerring an update to the system config span. These updates
currently drive only the propagation of zone configs to KV and cluster
settings. The cluster setting behavior is retained until we address #70566.
We have a history of these sorts of unsafe settings in
kv.raft_log.disable_synchronization_unsafe.Release note: None