Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: improve schema changes in testing setups #72447

Closed
postamar opened this issue Nov 4, 2021 · 3 comments
Closed

sql: improve schema changes in testing setups #72447

postamar opened this issue Nov 4, 2021 · 3 comments
Assignees
@ajwerner
Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@postamar
Copy link

postamar commented Nov 4, 2021 •
edited
Loading

Third-party tool test suites take significantly longer to run on CockroachDB compared to Postgres, hours compared to minutes. We've noticed in Active Record, Prisma, and TypeORM that frequent schema creation and changes contribute to test slowness.

This issue is created retroactively on behalf of @ajwerner to reference PRs related to this work:
#71910
#71899
#71909
#72297

Epic CRDB-10719
@postamar postamar added the C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) label Nov 4, 2021
@blathers-crl blathers-crl bot added the T-sql-schema-deprecated Use T-sql-foundations instead label Nov 4, 2021
@postamar postamar closed this as completed Nov 4, 2021
@otan
Copy link
Contributor

otan commented Nov 25, 2021

hmm, was this completed / everything merged into master?

@postamar
Copy link
Author

It doesn't seem that this is the case. Evidently I seem to have thought otherwise when I created the issue, but I can't remember why now. Strange. I'll reopen. cc @ajwerner

@postamar postamar reopened this Nov 26, 2021
@ajwerner
Copy link
Contributor

ajwerner commented Jan 5, 2022

Confirmed that this works on master and prisma-engines main.

@ajwerner ajwerner closed this as completed Jan 5, 2022
@exalate-issue-sync exalate-issue-sync bot added T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) and removed T-sql-schema-deprecated Use T-sql-foundations instead labels May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ajwerner ajwerner

Labels
C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ajwerner @postamar @otan