kvserver: skip some long tests under short #65792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
erikgrinaker
approved these changes
May 27, 2021
There was a problem hiding this comment.
You may want to skip TestRollbackSyncRangedIntentResolution and TestReliableIntentCleanup here as well.
Reviewed 2 of 2 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @andreimatei)
TestResetQuorum - 33s TestLearnerSnapshotFailsRollback - 90s TestReliableIntentCleanup - 80s Release note: None
andreimatei
force-pushed
the
small.skip-short
branch
from
9bdd9ea to
832bcb2
Compare
andreimatei
changed the title
andreimatei
commented
May 27, 2021
There was a problem hiding this comment.
TestRollbackSyncRangedIntentResolution was quick enough. I added TestReliableIntentCleanup (which is also always skipped currently cause it's flaky it seems).
bors r+
Reviewable status:
Yep, the txn heartbeater PR (#65592) is all about deflaking it. |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TestResetQuorum - 33s
TestLearnerSnapshotFailsRollback - 90s
TestReliableIntentCleanup - 80s
Release note: None