Skip to content

Commit 9bdd9ea

Browse files
committed
kvserver: skip TestResetQuorum, TestLearnerSnapshotFailsRollback under short
On my machine the first takes 33s, the second 90s. Release note: None
1 parent 53fc07d commit 9bdd9ea

File tree

2 files changed

+5
-0
lines changed

2 files changed

+5
-0
lines changed

pkg/kv/kvserver/replica_learner_test.go

+2
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,8 @@ func TestLearnerSnapshotFailsRollback(t *testing.T) {
309309
defer leaktest.AfterTest(t)()
310310
defer log.Scope(t).Close(t)
311311

312+
skip.UnderShort(t) // Takes 90s.
313+
312314
runTest := func(t *testing.T, replicaType roachpb.ReplicaType) {
313315
var rejectSnapshots int64
314316
knobs, ltk := makeReplicationTestKnobs()

pkg/kv/kvserver/reset_quorum_test.go

+3
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ import (
2727
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
2828
"github.com/cockroachdb/cockroach/pkg/testutils/testcluster"
2929
"github.com/cockroachdb/cockroach/pkg/util/leaktest"
30+
"github.com/cockroachdb/cockroach/pkg/util/log"
3031
"github.com/cockroachdb/errors"
3132
"github.com/stretchr/testify/require"
3233
)
@@ -51,9 +52,11 @@ import (
5152
// 6. A meta range (error expected).
5253
func TestResetQuorum(t *testing.T) {
5354
defer leaktest.AfterTest(t)()
55+
defer log.Scope(t).Close(t)
5456

5557
skip.UnderStress(t, "too many nodes")
5658
skip.UnderRace(t, "takes >1m under race")
59+
skip.UnderShort(t)
5760

5861
ctx := context.Background()
5962
livenessDuration := 3000 * time.Millisecond

0 commit comments

Comments
 (0)