Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql/pgwire: add telemetry for pgwire extended protcol #65679

Merged
merged 1 commit into from
May 26, 2021

Conversation

mneverov
Copy link
Contributor

@mneverov mneverov commented May 25, 2021

sql/pgwire: add telemetry for pgwire extended protcol

Fixes #65622

This PR adds telemetry counters for parse, bind, describe, and execute commands.

Release note: None

@blathers-crl
Copy link

blathers-crl bot commented May 25, 2021

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

I was unable to automatically find a reviewer. You can try CCing one of the following members:

  • A person you worked with closely on this PR.
  • The person who created the ticket, or a CRDB organization member involved with the ticket (author, commenter, etc.).
  • Join our community slack channel and ask on #contributors.
  • Try find someone else from here.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@blathers-crl blathers-crl bot added O-community Originated from the community X-blathers-untriaged blathers was unable to find an owner labels May 25, 2021
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor Author

@mneverov mneverov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @mneverov)

a discussion (no related file):
Note to the reviewer: please let me know if counters for close and flush messages should be added.


@mneverov mneverov force-pushed the telemetry_pgwire_extended branch from e0ad956 to 46cd81f Compare May 25, 2021 19:06
@blathers-crl
Copy link

blathers-crl bot commented May 25, 2021

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Yes, let's add close/flush telemetry

@rafiss
Copy link
Collaborator

rafiss commented May 26, 2021

cc @vy-ton

Fixes cockroachdb#65622
This PR adds telemetry counters for parse, bind, describe, and execute commands.

Release note: None
@mneverov mneverov force-pushed the telemetry_pgwire_extended branch from 46cd81f to 8403a59 Compare May 26, 2021 05:57
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!!

bors r+

@rafiss rafiss added backport-20.2.x and removed X-blathers-untriaged blathers was unable to find an owner labels May 26, 2021
@craig
Copy link
Contributor

craig bot commented May 26, 2021

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-community Originated from the community
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql/pgwire: add telemetry for pgwire extended protcol
3 participants