Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql/pgwire: add telemetry for pgwire extended protcol #65622

Closed
rafiss opened this issue May 24, 2021 · 1 comment · Fixed by #65679
Closed

sql/pgwire: add telemetry for pgwire extended protcol #65622

rafiss opened this issue May 24, 2021 · 1 comment · Fixed by #65679
Labels
A-sql-pgwire pgwire protocol issues. A-telemetry C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-starter Might be suitable for a starter project for new employees or team members. good first issue T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)

Comments

@rafiss
Copy link
Collaborator

rafiss commented May 24, 2021 •
edited by exalate-issue-sync bot
Loading

CockroachDB supports the pgwire extended protocol (https://www.postgresql.org/docs/current/protocol-flow.html#PROTOCOL-FLOW-EXT-QUERY) and many drivers use it by default.

Add telemetry to understand how much this protocol is used. The feature counters can be pgwire.command.parse, pgwire.command.bind , pgwire.command.describe , and pgwire.command.execute.

cc @vy-ton
@rafiss rafiss added C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) good first issue A-telemetry E-starter Might be suitable for a starter project for new employees or team members. A-sql-pgwire pgwire protocol issues. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels May 24, 2021
@mneverov
Copy link
Contributor

hi, i'd like to work on this

mneverov added a commit to mneverov/cockroach that referenced this issue May 25, 2021
@mneverov
sql/pgwire: add telemetry for pgwire extended protcol
46cd81f 
Fixes cockroachdb#65622
This PR adds telemetry counters for parse, bind, describe, and execute commands.

Release note: None
@mneverov mneverov mentioned this issue May 25, 2021
Merged
craig bot pushed a commit that referenced this issue May 26, 2021
@mneverov
Merge #65679
803ad8f 
65679: sql/pgwire: add telemetry for pgwire extended protcol r=rafiss a=mneverov

sql/pgwire: add telemetry for pgwire extended protcol

Fixes #65622

This PR adds telemetry counters for parse, bind, describe, and execute commands.

Release note: None

Co-authored-by: Max Neverov <[email protected]>
@craig craig bot closed this as completed in 8403a59 May 26, 2021
rafiss pushed a commit to rafiss/cockroach that referenced this issue May 27, 2021
@mneverov @rafiss
sql/pgwire: add telemetry for pgwire extended protcol
ef4766d 
Fixes cockroachdb#65622
This PR adds telemetry counters for parse, bind, describe, and execute commands.

Release note: None
This was referenced May 27, 2021
Merged
Merged
rafiss pushed a commit to rafiss/cockroach that referenced this issue May 27, 2021
@mneverov @rafiss
sql/pgwire: add telemetry for pgwire extended protcol
b016bad 
Fixes cockroachdb#65622
This PR adds telemetry counters for parse, bind, describe, and execute commands.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-sql-pgwire pgwire protocol issues. A-telemetry C-enhancement Solution expected to add code/behavior + preserve backward-compat (pg compat issues are exception) E-starter Might be suitable for a starter project for new employees or team members. good first issue T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql/pgwire: add telemetry for pgwire extended protcol mneverov/cockroach
2 participants
@mneverov @rafiss