tenantrate: fix test flake #63664
Merged
tenantrate: fix test flake #63664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
ajwerner
approved these changes
Apr 14, 2021
There was a problem hiding this comment.
Needs a make bazel-generate but
Reviewed 5 of 5 files at r1.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)
The way the test interacts with the configuration (through cluster settings) is flaky - when we modify multiple settings and the head of the queue gets notified, it might or might not observe the intermediary state. This commit cleans things up: the test now directly updates the config rather than going through the cluster settings. Fixes cockroachdb#63621. Release note: None
RaduBerinde
force-pushed
the
fix-tenantrate-flake
branch
from
00fb924 to
aace016
Compare
|
TFTR! bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the test interacts with the configuration (through cluster
settings) is flaky - when we modify multiple settings and the head of
the queue gets notified, it might or might not observe the
intermediary state.
This commit cleans things up: the test now directly updates the config
rather than going through the cluster settings.
Fixes #63621.
Release note: None