Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kv/kvserver/tenantrate: TestDataDriven failed #63621

Closed
cockroach-teamcity opened this issue Apr 14, 2021 · 0 comments · Fixed by #63664
Closed

kv/kvserver/tenantrate: TestDataDriven failed #63621

cockroach-teamcity opened this issue Apr 14, 2021 · 0 comments · Fixed by #63664
Assignees
@RaduBerinde
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.

Comments

@cockroach-teamcity
Copy link
Member

kv/kvserver/tenantrate.TestDataDriven failed with artifacts on master @ 3687e5646d15207e2248c219d725463097167318:

=== RUN   TestDataDriven
--- FAIL: TestDataDriven (45.15s)
=== RUN   TestDataDriven/update
I210414 06:15:20.336695 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 1  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:21.337706 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 2  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:22.338300 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 3  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:23.338943 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 4  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:24.339523 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 5  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:25.340311 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 6  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:26.340976 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 7  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:27.341664 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 8  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:28.342393 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 9  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:29.343121 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 10  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:30.343885 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 11  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:31.344512 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 12  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:32.345051 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 13  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:33.346045 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 14  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:34.346736 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 15  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:35.347279 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 16  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:36.347948 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 17  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:37.348503 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 18  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:38.349032 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 19  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:39.349611 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 20  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:40.350142 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 21  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:41.350768 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 22  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:42.351403 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 23  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:43.351966 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 24  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:44.352585 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 25  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:45.353093 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 26  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:46.353844 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 27  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:47.354488 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 28  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:48.355319 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 29  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:49.356147 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 30  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:50.357109 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 31  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:51.357814 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 32  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:52.358420 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 33  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:53.359004 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 34  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:54.359704 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 35  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:55.360274 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 36  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:56.361024 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 37  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:57.361625 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 38  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:58.362499 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 39  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:15:59.363218 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 40  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:16:00.364007 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 41  SucceedsSoon: got: "", exp: "00:00:02.000"
I210414 06:16:01.364601 116 kv/kvserver/tenantrate/limiter_test.go:117  [-] 42  SucceedsSoon: got: "", exp: "00:00:02.000"
    limiter_test.go:426: testdata/update:60: failed to find expected timers: got: "", exp: "00:00:02.000"
    --- FAIL: TestDataDriven/update (45.11s)
Reproduce

To reproduce, try: 

make stressrace TESTS=TestDataDriven PKG=./pkg/kv/kvserver/tenantrate TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

Parameters in this failure:

  • GOFLAGS=-race -parallel=4

/cc @ajwerner

This test on roachdash | Improve this report!
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Apr 14, 2021
RaduBerinde added a commit to RaduBerinde/cockroach that referenced this issue Apr 14, 2021
@RaduBerinde
tenantrate: fix test flake
00fb924 
The way the test interacts with the configuration (through cluster
settings) is flaky - when we modify multiple settings and the head of
the queue gets notified, it might or might not observe the
intermediary state.

This commit cleans things up: the test now directly updates the config
rather than going through the cluster settings.

Fixes cockroachdb#63621.

Release note: None
@RaduBerinde RaduBerinde mentioned this issue Apr 14, 2021
Merged
craig bot pushed a commit that referenced this issue Apr 15, 2021
@RaduBerinde
Merge #63664
29b6209 
63664: tenantrate: fix test flake r=RaduBerinde a=RaduBerinde

The way the test interacts with the configuration (through cluster
settings) is flaky - when we modify multiple settings and the head of
the queue gets notified, it might or might not observe the
intermediary state.

This commit cleans things up: the test now directly updates the config
rather than going through the cluster settings.

Fixes #63621.

Release note: None

Co-authored-by: Radu Berinde <[email protected]>
@craig craig bot closed this as completed in aace016 Apr 15, 2021
RaduBerinde added a commit to RaduBerinde/cockroach that referenced this issue May 24, 2021
@RaduBerinde
tenantrate: fix test flake
f6b620d 
The way the test interacts with the configuration (through cluster
settings) is flaky - when we modify multiple settings and the head of
the queue gets notified, it might or might not observe the
intermediary state.

This commit cleans things up: the test now directly updates the config
rather than going through the cluster settings.

Fixes cockroachdb#63621.

Release note: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RaduBerinde RaduBerinde

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tenantrate: fix test flake RaduBerinde/cockroach
2 participants
@RaduBerinde @cockroach-teamcity