Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "roachtest: enable jemalloc profiling in all roachtests" #54612

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Revert "roachtest: enable jemalloc profiling in all roachtests" #54612

merged 1 commit into from
Sep 21, 2020

Conversation

knz
Copy link
Contributor

@knz knz commented Sep 21, 2020

This reverts commit 2d69b3d.

As discussed in #54515

Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@knz knz mentioned this pull request Sep 21, 2020
Closed
petermattis
petermattis approved these changes Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@petermattis petermattis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Do you think we should enable jemalloc profiling for the bulk IO tests?

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @nvanbenschoten and @petermattis)

@knz
Copy link
Contributor Author

knz commented Sep 21, 2020

Do you think we should enable jemalloc profiling for the bulk IO tests?

I don't know. @dt what do you think?

In the meantime I'll go ahead and merge this.

bors r=petermattis

@dt
Copy link
Member

dt commented Sep 21, 2020

The OOMing bulk test I think ended up being blamed on go mem usage, related to snapshots, and i’m not sure if jemalloc profiles would have helped much — the amount of cgo mem we were seeing, IIRC, was at least close to rough expectations I think? I’m apathetic about doing something special for bulk tests (to me the bigger problem is timing of the profile vs the crash but that’s another issue)

@craig
Copy link
Contributor

craig bot commented Sep 21, 2020

Build succeeded:

@craig craig bot merged commit dca4540 into cockroachdb:master Sep 21, 2020
@knz knz deleted the 20200921-revert-jemalloc branch September 21, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petermattis petermattis petermattis approved these changes

@nvanbenschoten nvanbenschoten Awaiting requested review from nvanbenschoten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knz @cockroach-teamcity @dt @petermattis