Skip to content

Commit

Permalink
Merge #54612
Browse files Browse the repository at this point in the history
54612: Revert "roachtest: enable jemalloc profiling in all roachtests" r=petermattis a=knz

This reverts commit 2d69b3d.

As discussed in #54515

Release note: None

Co-authored-by: Raphael 'kena' Poss <[email protected]>
  • Loading branch information
craig[bot] and knz committed Sep 21, 2020
2 parents 3202b17 + 752881e commit dca4540
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions pkg/cmd/roachtest/cluster.go
Original file line number Diff line number Diff line change
Expand Up @@ -2124,20 +2124,12 @@ func (c *cluster) StartE(ctx context.Context, opts ...option) error {
}
args = append(args, roachprodArgs(opts)...)
args = append(args, c.makeNodes(opts...))
// Enable Jemalloc profiles for all roachtests. This has only
// minimal performance impact and significantly improves the
// troubleshootability of memory-related issues.
args = append(args, enableJemallocArgs()...)
if !argExists(args, "--encrypt") && c.encryptDefault {
args = append(args, "--encrypt")
}
return execCmd(ctx, c.l, args...)
}

func enableJemallocArgs() []string {
return []string{"-e", "MALLOC_CONF=prof:true"}
}

// Start is like StartE() except it takes a test and, on error, calls t.Fatal().
func (c *cluster) Start(ctx context.Context, t *test, opts ...option) {
FatalIfErr(t, c.StartE(ctx, opts...))
Expand Down

0 comments on commit dca4540

Please sign in to comment.