Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: temporarily skip TestPartialZip and CDC tests #51542

Merged
merged 2 commits into from
Jul 17, 2020
Merged

cli: temporarily skip TestPartialZip and CDC tests #51542

merged 2 commits into from
Jul 17, 2020

Conversation

knz
Copy link
Contributor

@knz knz commented Jul 17, 2020

Due to #51538

Release note: None

@knz knz requested a review from tbg July 17, 2020 08:08
@knz knz requested a review from a team as a code owner July 17, 2020 08:08
@cockroach-teamcity
Copy link
Member

This change is Reviewable

tbg
tbg approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@knz
Copy link
Contributor Author

knz commented Jul 17, 2020

bors r=tbg

@craig
Copy link
Contributor

craig bot commented Jul 17, 2020

Canceled (will resume)

@knz
Copy link
Contributor Author

knz commented Jul 17, 2020

bors r-

bors r=tbg

@craig
Copy link
Contributor

craig bot commented Jul 17, 2020

Canceled

@knz
Copy link
Contributor Author

knz commented Jul 17, 2020

the CI is flaking on #51543

@craig
Copy link
Contributor

craig bot commented Jul 17, 2020

Canceled

@knz
Copy link
Contributor Author

knz commented Jul 17, 2020

Skipping the CDC tests

@knz
Copy link
Contributor Author

knz commented Jul 17, 2020

bors r=tbg

@knz knz changed the title cli: temporarily skip TestPartialZip cli: temporarily skip TestPartialZip and CDC tests Jul 17, 2020
@knz
Copy link
Contributor Author

knz commented Jul 17, 2020

The CI is flaking on #51544 and unfortunately I can't skip that.

@craig
Copy link
Contributor

craig bot commented Jul 17, 2020

Canceled

@knz
Copy link
Contributor Author

knz commented Jul 17, 2020

typo 🤦

@knz
Copy link
Contributor Author

knz commented Jul 17, 2020

bors r-

@knz
Copy link
Contributor Author

knz commented Jul 17, 2020

bors r=tbg

@craig
Copy link
Contributor

craig bot commented Jul 17, 2020

Build succeeded

@craig craig bot merged commit 5149293 into cockroachdb:master Jul 17, 2020
@knz knz deleted the 20200717-zip branch July 17, 2020 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbg tbg tbg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@knz @cockroach-teamcity @tbg