Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli: TestPartialZip failed #51538

Closed
cockroach-teamcity opened this issue Jul 17, 2020 · 1 comment
Closed

cli: TestPartialZip failed #51538

cockroach-teamcity opened this issue Jul 17, 2020 · 1 comment
Assignees
@tbg
Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Milestone
20.2

Comments

@cockroach-teamcity
Copy link
Member

(cli).TestPartialZip failed on master@af0031e3004327b8d09e23e99eb9659abf7d82de:

=== RUN   TestPartialZip
    TestPartialZip: test_log_scope.go:77: test logs captured to: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestPartialZip256663256
    TestPartialZip: test_log_scope.go:58: use -show-logs to present logs inline
    TestPartialZip: datadriven.go:194: output didn't match expected:
        @@ -24,15 +24,15 @@
         retrieving SQL data for crdb_internal.partitions... writing: debug/crdb_internal.partitions.txt
         retrieving SQL data for crdb_internal.zones... writing: debug/crdb_internal.zones.txt
         requesting nodes... writing: debug/nodes.json
         requesting liveness... writing: debug/liveness.json
         requesting CPU profiles... ok
        -writing: debug/nodes/1/cpu.pprof
        +writing: debug/nodes/1/cpu.pprof.err.txt
        +  ^- resulted in ...
         writing: debug/nodes/2/cpu.pprof.err.txt
           ^- resulted in ...
        -writing: debug/nodes/3/cpu.pprof.err.txt
        -  ^- resulted in ...
        +writing: debug/nodes/3/cpu.pprof
         writing: debug/nodes/1/status.json
         using SQL connection URL for node 1: postgresql://...
         retrieving SQL data for crdb_internal.feature_usage... writing: debug/nodes/1/crdb_internal.feature_usage.txt
         retrieving SQL data for crdb_internal.gossip_alerts... writing: debug/nodes/1/crdb_internal.gossip_alerts.txt
         retrieving SQL data for crdb_internal.gossip_liveness... writing: debug/nodes/1/crdb_internal.gossip_liveness.txt
test logs left over in: /go/src/github.com/cockroachdb/cockroach/artifacts/logTestPartialZip256663256
--- FAIL: TestPartialZip (6.34s)
More

Parameters:

  • TAGS=
  • GOFLAGS=-parallel=4
make stressrace TESTS=TestPartialZip PKG=./pkg/cli TESTTIMEOUT=5m STRESSFLAGS='-timeout 5m' 2>&1

See this test on roachdash
powered by pkg/cmd/internal/issues
@cockroach-teamcity cockroach-teamcity added branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot. labels Jul 17, 2020
@cockroach-teamcity cockroach-teamcity added this to the 20.2 milestone Jul 17, 2020
@knz
Copy link
Contributor

knz commented Jul 17, 2020

@tbg I think that's fallout from your pprof PR.

@knz knz assigned tbg and unassigned knz Jul 17, 2020
knz added a commit to knz/cockroach that referenced this issue Jul 17, 2020
@knz
cli: temporarily skip TestPartialZip
89b08ab 
Due to cockroachdb#51538

Release note: None
This was referenced Jul 17, 2020
Merged
Merged
craig bot pushed a commit that referenced this issue Jul 17, 2020
@knz
Merge #51502 #51542
5149293 
51502: security,sql: add a setting to constrain the minimum password length r=RichardJCai a=knz

Requested by @bdarnell.

First commit from #51501.

This change adds a new cluster setting
`server.user_login.min_password_length`. When set and non-zero, it
forces a minimum password length to passwords passed in cleartext to
the SQL `WITH PASSWORD` clause (`CREATE/ALTER USER/ROLE`).

This change is part of a larger set of security measures to help
the secure deployment of Cockroach Cloud. We are not yet planning
to advertise this to on-prem users until the feature matures and
is complemented by additional enhancements to password authentication.

cc @solongordon @thtruo @aaron-crl for visibility.

51542: cli: temporarily skip TestPartialZip and CDC tests r=tbg a=knz

Due to #51538

Release note: None

Co-authored-by: Raphael 'kena' Poss <[email protected]>
@craig craig bot closed this as completed in 2efe1fa Aug 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbg tbg

Labels
branch-master Failures and bugs on the master branch. C-test-failure Broken test (automatically or manually discovered). O-robot Originated from a bot.
Projects
None yet
Milestone
20.2
Development

No branches or pull requests
3 participants
@knz @tbg @cockroach-teamcity