DNM: storage: Test for merge/WaitForApplication bug #35653
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prevents on-disk inconsistencies when a node crashes in the middle of a merge and the lease applied index temporarily regresses. Fixes cockroachdb#33120 Release note (bug fix): Fixed an on-disk inconsistency that could result from a crash during a range merge.
This test fails with the "overlapping range" error if the WriteSyncNoop call is removed. Release note: None
|
This change is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split from #35626. The code here currently reproduces the problem if the WriteSyncNoop call is removed (and passes with it), but it's not yet a proper test.