storage: Sync to disk before returning in WaitForApplication #35626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
bdarnell
force-pushed
the
merge-waitforapplication
branch
from
3189799 to
2dcec7d
Compare
bdarnell
changed the title
tbg
approved these changes
Mar 12, 2019
bdarnell
force-pushed
the
merge-waitforapplication
branch
from
2dcec7d to
b93ae62
Compare
This prevents on-disk inconsistencies when a node crashes in the middle of a merge and the lease applied index temporarily regresses. Fixes cockroachdb#33120 Release note (bug fix): Fixed an on-disk inconsistency that could result from a crash during a range merge.
bdarnell
force-pushed
the
merge-waitforapplication
branch
from
b93ae62 to
68e34eb
Compare
|
bors r=tbg |
craig bot
pushed a commit
that referenced
this pull request
Mar 12, 2019
35626: storage: Sync to disk before returning in WaitForApplication r=tbg a=bdarnell This prevents on-disk inconsistencies when a node crashes in the middle of a merge and the lease applied index temporarily regresses. Fixes #33120 Release note (bug fix): Fixed an on-disk inconsistency that could result from a crash during a range merge. The second commit is a manual test (adapted from @tbg) that demonstrates the "overlapping range" failure if the WriteSyncNoop call is removed, and also shows that this call fixes the problem. It's obviously not mergeable in its current state, but I'm not sure how to test this without some gross hacks. Co-authored-by: Ben Darnell <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents on-disk inconsistencies when a node crashes in the
middle of a merge and the lease applied index temporarily regresses.
Fixes #33120
Release note (bug fix): Fixed an on-disk inconsistency that could
result from a crash during a range merge.
The second commit is a manual test (adapted from @tbg) that demonstrates the "overlapping range" failure if the WriteSyncNoop call is removed, and also shows that this call fixes the problem. It's obviously not mergeable in its current state, but I'm not sure how to test this without some gross hacks.