-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: ui: omit tenant selector in Metrics when only one exists #122909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ca05aa2
to
c4868ab
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
xinhaoz
approved these changes
Apr 30, 2024
Reminder: it has been 3 weeks please merge or close your backport! |
laurenbarker
approved these changes
Jun 3, 2024
The "Virtual Cluster" selector on the Metrics page should only be present when we have more than one tenant on the cluster. Previously, the code that decided this did not account for the fact that an additional "All" option was always present in the dropdown and mistook it for a tenant when counting. Resolves: #114168 Epic: None Release note: None
c4868ab
to
8857123
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport
Label PR's that are backports to older release branches
blathers-backport
This is a backport that Blathers created automatically.
no-backport-pr-activity
O-robot
Originated from a bot.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #119882 on behalf of @dhartunian.
/cc @cockroachdb/release
The "Virtual Cluster" selector on the Metrics page should only be present when we have more than one tenant on the cluster. Previously, the code that decided this did not account for the fact that an additional "All" option was always present in the dropdown and mistook it for a tenant when counting.
Resolves: #114168
Epic: None
Release note: None
Release justification: low risk high impact bugfix to reduce confusion in DB Console for standard deployments