Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-23.2: ui: omit tenant selector in Metrics when only one exists #122909

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Apr 23, 2024

Backport 1/1 commits from #119882 on behalf of @dhartunian.

/cc @cockroachdb/release


The "Virtual Cluster" selector on the Metrics page should only be present when we have more than one tenant on the cluster. Previously, the code that decided this did not account for the fact that an additional "All" option was always present in the dropdown and mistook it for a tenant when counting.

Resolves: #114168
Epic: None

Release note: None


Release justification: low risk high impact bugfix to reduce confusion in DB Console for standard deployments

@blathers-crl blathers-crl bot requested a review from a team April 23, 2024 17:12
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.2-119882 branch from ca05aa2 to c4868ab Compare April 23, 2024 17:12
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Apr 23, 2024
@blathers-crl blathers-crl bot requested review from dhartunian and xinhaoz April 23, 2024 17:12
Copy link
Author

blathers-crl bot commented Apr 23, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL and one additional
    TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Apr 23, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@dhartunian dhartunian requested a review from stevendanna April 30, 2024 22:37
Copy link

Reminder: it has been 3 weeks please merge or close your backport!

The "Virtual Cluster" selector on the Metrics page should only be
present when we have more than one tenant on the cluster. Previously,
the code that decided this did not account for the fact that an
additional "All" option was always present in the dropdown and mistook
it for a tenant when counting.

Resolves: #114168
Epic: None

Release note: None
@dhartunian dhartunian force-pushed the blathers/backport-release-23.2-119882 branch from c4868ab to 8857123 Compare June 3, 2024 17:27
@dhartunian dhartunian requested a review from a team as a code owner June 3, 2024 17:27
@dhartunian dhartunian merged commit 046ce36 into release-23.2 Jun 3, 2024
5 of 6 checks passed
@dhartunian dhartunian deleted the blathers/backport-release-23.2-119882 branch June 3, 2024 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches blathers-backport This is a backport that Blathers created automatically. no-backport-pr-activity O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants