ui: omit tenant selector in Metrics when only one exists #119882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhartunian
requested review from
a team and
xinhaoz
and removed request for
a team
|
This change is |
xinhaoz
approved these changes
Mar 6, 2024
| tenantOptions: DropdownOption[], | ||
| ): boolean => { | ||
| return ( | ||
| tenantOptions.filter( |
There was a problem hiding this comment.
nit: You can also accomplish this with tenantOptions.some( t => t.label !== SYSTEM_TENANT_NAME && t.label !== ALL_TENANTS_OPTION.label) which won't have to operate on the entire array / create a new one.
Feel free to ignore though as this array is likely always quite small anyway.
dhartunian
force-pushed
the
tenant-dropdown-bugs
branch
from
f1adf50 to
881f2d1
Compare
The "Virtual Cluster" selector on the Metrics page should only be present when we have more than one tenant on the cluster. Previously, the code that decided this did not account for the fact that an additional "All" option was always present in the dropdown and mistook it for a tenant when counting. Resolves: cockroachdb#114168 Epic: None Release note: None
dhartunian
force-pushed
the
tenant-dropdown-bugs
branch
from
881f2d1 to
4b97017
Compare
|
TFTR bors r=xinhaoz |
|
Build succeeded: |
|
blathers backport 23.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Virtual Cluster" selector on the Metrics page should only be present when we have more than one tenant on the cluster. Previously, the code that decided this did not account for the fact that an additional "All" option was always present in the dropdown and mistook it for a tenant when counting.
Resolves: #114168
Epic: None
Release note: None