roachtest: delete synctest #106917
Merged
roachtest: delete synctest #106917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumeerbhola
requested review from
smg260 and
renatolabs
and removed request for
a team
|
This change is |
RaduBerinde
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @jbowens, @renatolabs, and @smg260)
This test has been skipped since May 2020, because Pebble code is written to crash on an error when writing to the MANIFEST and the WAL, since it is not viable to continue. Additionally, there were problems with hangs due to charybdefs returning EAGAIN (which have since been fixed). We are deleting this now since: - The purpose of this test is to test that Pebble does not lose data due to filesystem errors. It does so in a cruder manner than Pebble's strict MemFS based testing (which came later). Given the existence of the latter, there is no good reason to retain this test. - Working around charybdefs flakiness (see cockroachdb#102492), and Pebble's failstop-on-error behavior is not worth the initial and ongoing maintenance effort. Epic: none Fixes: cockroachdb#48603 Release note: None
itsbilal
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Reviewable status:
|
TFTR! |
|
flaky tests |
|
bors r=RaduBerinde,itsbilal |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test has been skipped since May 2020, because Pebble code is written to crash on an error when writing to the MANIFEST and the WAL, since it is not viable to continue. Additionally, there were problems with hangs due to charybdefs returning EAGAIN (which have since been fixed).
We are deleting this now since:
The purpose of this test is to test that Pebble does not lose data due to filesystem errors. It does so in a cruder manner than Pebble's strict MemFS based testing (which came later). Given the existence of the latter, there is no good reason to retain this test.
Working around charybdefs flakiness (see roachtest: remove the FUSE-variants of the disk-stall roachtest #102492), and Pebble's failstop-on-error behavior is not worth the initial and ongoing maintenance effort.
Epic: none
Fixes: #48603
Release note: None